s3-lsa: use switch in _lsa_QuerySecurity().
authorGünther Deschner <gd@samba.org>
Thu, 29 Oct 2009 11:36:30 +0000 (12:36 +0100)
committerGünther Deschner <gd@samba.org>
Fri, 30 Oct 2009 11:28:48 +0000 (12:28 +0100)
Guenther

source3/rpc_server/srv_lsa_nt.c

index d90dfeed98a050abf372ae2719ab427f82cba81d..a806a22907ea439f1a312101c096a4db975f9d5a 100644 (file)
@@ -2089,15 +2089,19 @@ NTSTATUS _lsa_QuerySecurity(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&handle))
                return NT_STATUS_INVALID_HANDLE;
 
-       if (handle->type == LSA_HANDLE_POLICY_TYPE) {
+       switch (handle->type) {
+       case LSA_HANDLE_POLICY_TYPE:
                status = make_lsa_object_sd(p->mem_ctx, &psd, &sd_size,
                                &lsa_policy_mapping, NULL, 0);
-       } else if (handle->type == LSA_HANDLE_ACCOUNT_TYPE) {
+               break;
+       case LSA_HANDLE_ACCOUNT_TYPE:
                status = make_lsa_object_sd(p->mem_ctx, &psd, &sd_size,
                                &lsa_account_mapping,
                                &handle->sid, LSA_ACCOUNT_ALL_ACCESS);
-       } else {
+               break;
+       default:
                status = NT_STATUS_INVALID_HANDLE;
+               break;
        }
 
        if (!NT_STATUS_IS_OK(status)) {