r17866: Fix possible null deref - found by Stanford checker.
authorJeremy Allison <jra@samba.org>
Mon, 28 Aug 2006 02:27:49 +0000 (02:27 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 16:38:55 +0000 (11:38 -0500)
Jeremy.

source/lib/util_str.c

index 2b647b0641baa4c0b74568b1f45f8e3bb4e3d6ae..8639a9bc07a0890433abc7f6accbf2cce09d90e5 100644 (file)
@@ -2056,7 +2056,7 @@ char* ipstr_list_make(char** ipstr_list, const struct ip_service* ip_list, int i
        int i;
        
        /* arguments checking */
-       if (!ip_list && !ipstr_list) return 0;
+       if (!ip_list || !ipstr_list) return 0;
 
        *ipstr_list = NULL;