git.samba.org
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
94e41a8
)
ctdb-common: Avoid unused value warning
author
Martin Schwenke
<martin@meltin.net>
Thu, 23 May 2019 07:53:19 +0000
(17:53 +1000)
committer
Amitay Isaacs
<amitay@samba.org>
Wed, 5 Jun 2019 10:25:50 +0000
(10:25 +0000)
The incremented value of argc is indeed never used. Leave it as a
comment to warn anyone cutting and pasting the code.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb/common/run_event.c
patch
|
blob
|
history
diff --git
a/ctdb/common/run_event.c
b/ctdb/common/run_event.c
index 3682f77876807f71d7975c932728406d9c0ae737..ca4e572a80611a6163fc51278ece08ae743854e9 100644
(file)
--- a/
ctdb/common/run_event.c
+++ b/
ctdb/common/run_event.c
@@
-146,7
+146,7
@@
static int script_args(TALLOC_CTX *mem_ctx, const char *event_str,
}
argv[argc] = NULL;
- argc += 1;
+ /* argc += 1 */
*out = argv;
return 0;