s3: rpcclient: Prevent null ptr access by returning error if no creds available

Prevent rpccli_netlogon_password_logon being called with 'NULL' credentials.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11569

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/source3/rpcclient/cmd_netlogon.c b/source3/rpcclient/cmd_netlogon.c
index 0a8ab205f8ad7eef1cea3036f261e1166059e22f..744361c4a478beab96d5673f0fee6fed9b2f0ae9 100644 (file)
--- a/source3/rpcclient/cmd_netlogon.c
+++ b/source3/rpcclient/cmd_netlogon.c
@@ -800,6 +800,11 @@ static NTSTATUS cmd_netlogon_sam_logon(struct rpc_pipe_client *cli,
        if (argc == 6)
                sscanf(argv[5], "%x", &logon_param);
 
+       if (rpcclient_netlogon_creds == NULL) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
        /* Perform the sam logon */
 
        result = rpccli_netlogon_password_logon(rpcclient_netlogon_creds,