vfs_fruit: mmap under FreeBSD needs PROT_READ
authorVolker Lendecke <vl@samba.org>
Thu, 8 Jan 2015 16:14:37 +0000 (17:14 +0100)
committerKarolin Seeger <kseeger@samba.org>
Thu, 15 Jan 2015 15:16:51 +0000 (16:16 +0100)
We memmove, which does read

Bug: https://bugzilla.samba.org/show_bug.cgi?id=11040

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Böhme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 56e2384dfe29fd8f16b9d0cf7264f9bb8ed38966)

Autobuild-User(v4-2-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-2-test): Thu Jan 15 16:16:51 CET 2015 on sn-devel-104

source3/modules/vfs_fruit.c

index 253b459523cba838379eac292821ee18d6951beb..3588d56b543efce48a9c32e852322486bcf431e7 100644 (file)
@@ -651,7 +651,7 @@ static int ad_convert(struct adouble *ad, int fd)
                ad_getentrylen(ad, ADEID_RFORK);
 
        /* FIXME: direct use of mmap(), vfs_aio_fork does it too */
-       map = mmap(NULL, origlen, PROT_WRITE, MAP_SHARED, fd, 0);
+       map = mmap(NULL, origlen, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0);
        if (map == MAP_FAILED) {
                DEBUG(2, ("mmap AppleDouble: %s\n", strerror(errno)));
                rc = -1;