librpc:ndr: Don’t unnecessarily parenthesize macro arguments
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Thu, 30 Nov 2023 02:31:32 +0000 (15:31 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 21 Dec 2023 20:21:34 +0000 (20:21 +0000)
If we’re just passing a parameter to another macro which we know
correctly parenthesizes its arguments, then we don’t need to
parenthesize the parameter ourselves.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
librpc/ndr/ndr_basic.c

index eae0fd062cb05c15e2c6b1450cc3b23d3f81b572..fc8620f28c77e8ef68dcb71d67d3e9215687bab2 100644 (file)
@@ -37,7 +37,7 @@
        (int32_t)(NDR_BE(ndr) ? PULL_BE_U32(ndr->data,ofs) : PULL_LE_U32(ndr->data,ofs))
 
 #define NDR_PULL_I64(ndr, ofs) \
-       (NDR_BE(ndr) ? PULL_BE_I64((ndr)->data, (ofs)) : PULL_LE_I64((ndr)->data, (ofs)))
+       (NDR_BE(ndr) ? PULL_BE_I64((ndr)->data, ofs) : PULL_LE_I64((ndr)->data, ofs))
 
 #define NDR_PUSH_U16(ndr, ofs, v) \
        do { \
@@ -69,9 +69,9 @@
 #define NDR_PUSH_I64(ndr, ofs, v) \
        do { \
                if (NDR_BE(ndr)) { \
-                       PUSH_BE_I64((ndr)->data, (ofs), (v));   \
+                       PUSH_BE_I64((ndr)->data, ofs, v);       \
                } else { \
-                       PUSH_LE_I64((ndr)->data, (ofs), (v));   \
+                       PUSH_LE_I64((ndr)->data, ofs, v);       \
                } \
        } while (0)