The ldb async merge broke all MMC management utilties
authorMatthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
Tue, 14 Oct 2008 00:02:42 +0000 (11:02 +1100)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 14 Oct 2008 00:16:23 +0000 (11:16 +1100)
Commit 51baa8deec00244cc0a6e3d29c53932427800610 included a
copy-and-paste bug which caused all MMC mangement utilities to break.

Because of the typo Samba4 would no longer include the magic 'you may
write to these attributes/create these classes' attributes, these
tools would display all fields greyed out or 'read only', and not
allow the creation of child objects.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
source4/dsdb/samdb/ldb_modules/kludge_acl.c

index 865e1c7286823bdbd61c5607a97f9c26dc426151..6acbf45afd8653c7c526fa18b92cf6f4a6b52225 100644 (file)
@@ -250,14 +250,14 @@ static int kludge_acl_callback(struct ldb_request *req, struct ldb_reply *ares)
                        case SECURITY_SYSTEM:
                                if (ac->allowedAttributesEffective) {
                                        ret = kludge_acl_allowedAttributes(ac->module->ldb, ares->message,
-                                                                       "allowedClassesAttributesEffective");
+                                                                       "allowedAttributesEffective");
                                        if (ret != LDB_SUCCESS) {
                                                return ldb_module_done(ac->req, NULL, NULL, ret);
                                        }
                                }
                                if (ac->allowedChildClassesEffective) {
                                        ret = kludge_acl_childClasses(ac->module->ldb, ares->message,
-                                                                       "allowedClassesChildClassesEffective");
+                                                                       "allowedChildClassesEffective");
                                        if (ret != LDB_SUCCESS) {
                                                return ldb_module_done(ac->req, NULL, NULL, ret);
                                        }
@@ -267,14 +267,14 @@ static int kludge_acl_callback(struct ldb_request *req, struct ldb_reply *ares)
                        case SECURITY_ADMINISTRATOR:
                                if (ac->allowedAttributesEffective) {
                                        ret = kludge_acl_allowedAttributes(ac->module->ldb, ares->message,
-                                                                       "allowedClassesAttributesEffective");
+                                                                       "allowedAttributesEffective");
                                        if (ret != LDB_SUCCESS) {
                                                return ldb_module_done(ac->req, NULL, NULL, ret);
                                        }
                                }
                                if (ac->allowedChildClassesEffective) {
                                        ret = kludge_acl_childClasses(ac->module->ldb, ares->message,
-                                                                       "allowedClassesChildClassesEffective");
+                                                                       "allowedChildClassesEffective");
                                        if (ret != LDB_SUCCESS) {
                                                return ldb_module_done(ac->req, NULL, NULL, ret);
                                        }