s4:dcesrv_samr: always use mem_ctx as initial parent for samr_*_state
authorStefan Metzmacher <metze@samba.org>
Fri, 23 Oct 2009 15:30:47 +0000 (17:30 +0200)
committerStefan Metzmacher <metze@samba.org>
Sat, 24 Oct 2009 09:59:16 +0000 (11:59 +0200)
We always steal the state to the policy handle on success,
but untill then keep it on the short term context.

metze

source4/rpc_server/samr/dcesrv_samr.c

index 08f14716657a564a70187e056b6b28e4a913c151..7be1cf9813cc2c3e9987649a1b5370f7108e88c7 100644 (file)
@@ -165,7 +165,7 @@ static NTSTATUS dcesrv_samr_Connect(struct dcesrv_call_state *dce_call, TALLOC_C
 
        ZERO_STRUCTP(r->out.connect_handle);
 
-       c_state = talloc(dce_call->conn, struct samr_connect_state);
+       c_state = talloc(mem_ctx, struct samr_connect_state);
        if (!c_state) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -398,7 +398,7 @@ static NTSTATUS dcesrv_samr_OpenDomain(struct dcesrv_call_state *dce_call, TALLO
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       d_state = talloc(c_state, struct samr_domain_state);
+       d_state = talloc(mem_ctx, struct samr_domain_state);
        if (!d_state) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -1040,7 +1040,7 @@ static NTSTATUS dcesrv_samr_CreateDomainGroup(struct dcesrv_call_state *dce_call
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       a_state = talloc(d_state, struct samr_account_state);
+       a_state = talloc(mem_ctx, struct samr_account_state);
        if (!a_state) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -1333,7 +1333,7 @@ static NTSTATUS dcesrv_samr_CreateUser2(struct dcesrv_call_state *dce_call, TALL
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       a_state = talloc(d_state, struct samr_account_state);
+       a_state = talloc(mem_ctx, struct samr_account_state);
        if (!a_state) {
                ldb_transaction_cancel(d_state->sam_ctx);
                return NT_STATUS_NO_MEMORY;
@@ -1614,7 +1614,7 @@ static NTSTATUS dcesrv_samr_CreateDomAlias(struct dcesrv_call_state *dce_call, T
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       a_state = talloc(d_state, struct samr_account_state);
+       a_state = talloc(mem_ctx, struct samr_account_state);
        if (!a_state) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -2043,7 +2043,7 @@ static NTSTATUS dcesrv_samr_OpenGroup(struct dcesrv_call_state *dce_call, TALLOC
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       a_state = talloc(d_state, struct samr_account_state);
+       a_state = talloc(mem_ctx, struct samr_account_state);
        if (!a_state) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -2520,7 +2520,7 @@ static NTSTATUS dcesrv_samr_OpenAlias(struct dcesrv_call_state *dce_call, TALLOC
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       a_state = talloc(d_state, struct samr_account_state);
+       a_state = talloc(mem_ctx, struct samr_account_state);
        if (!a_state) {
                return NT_STATUS_NO_MEMORY;
        }