Fix off by one bug noticed by Andrew Bartlett.
authorJeremy Allison <jra@samba.org>
Fri, 14 Mar 2003 02:10:26 +0000 (02:10 +0000)
committerJeremy Allison <jra@samba.org>
Fri, 14 Mar 2003 02:10:26 +0000 (02:10 +0000)
Jeremy.
(This used to be commit 759aab9944e8dc5c38e224ace738b75ded07ee54)

source3/printing/nt_printing.c

index 74a9ac8174a496e285d4538976d98752b2d667bd..3f5bf555349e050387f4511d078770a89477760f 100644 (file)
@@ -2110,7 +2110,7 @@ done:
 NT_DEVICEMODE *construct_nt_devicemode(const fstring default_devicename)
 {
 
-       char adevice[MAXDEVICENAME];
+       char adevice[MAXDEVICENAME+1];
        NT_DEVICEMODE *nt_devmode = (NT_DEVICEMODE *)malloc(sizeof(NT_DEVICEMODE));
 
        if (nt_devmode == NULL) {
@@ -2120,7 +2120,7 @@ NT_DEVICEMODE *construct_nt_devicemode(const fstring default_devicename)
 
        ZERO_STRUCTP(nt_devmode);
 
-       safe_strcpy(adevice, default_devicename, sizeof(adevice));
+       safe_strcpy(adevice, default_devicename, sizeof(adevice)-1);
        fstrcpy(nt_devmode->devicename, adevice);       
        
        fstrcpy(nt_devmode->formname, "Letter");