s3: VFS: Remove logically dead code. Coverity CID: 1419117
authorJeremy Allison <jra@samba.org>
Fri, 9 Nov 2018 19:23:21 +0000 (11:23 -0800)
committerJeremy Allison <jra@samba.org>
Wed, 14 Nov 2018 20:35:45 +0000 (21:35 +0100)
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Nov 14 21:35:45 CET 2018 on sn-devel-144

source3/smbd/vfs.c

index 28ebfc92dc73fd9ef260d165b991c898ac0d85d5..351cd0a55671d45762648f96a968f42a250ca8d2 100644 (file)
@@ -787,7 +787,6 @@ const char *vfs_readdirname(connection_struct *conn, void *p,
 int vfs_ChDir(connection_struct *conn, const struct smb_filename *smb_fname)
 {
        int ret;
-       int saved_errno = 0;
        struct smb_filename *old_cwd = conn->cwd_fname;
 
        if (!LastDir) {
@@ -825,7 +824,7 @@ int vfs_ChDir(connection_struct *conn, const struct smb_filename *smb_fname)
                 * Return to original directory
                 * and return -1.
                 */
-               saved_errno = errno;
+               int saved_errno = errno;
 
                if (old_cwd == NULL) {
                        /*
@@ -860,9 +859,6 @@ int vfs_ChDir(connection_struct *conn, const struct smb_filename *smb_fname)
        DEBUG(4,("vfs_ChDir got %s\n", conn->cwd_fname->base_name));
 
        TALLOC_FREE(old_cwd);
-       if (saved_errno != 0) {
-               errno = saved_errno;
-       }
        return ret;
 }