s4:ntvfs: use NUMERIC_CMP in stream_name_cmp
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Tue, 2 Apr 2024 23:52:50 +0000 (12:52 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 10 Apr 2024 22:56:33 +0000 (22:56 +0000)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/ntvfs/posix/pvfs_streams.c

index 9210237167458a6f32f34d438af8f66b4b8b5593..d2d5eed13549e39e35d48a2743479512fe156526 100644 (file)
@@ -22,6 +22,7 @@
 #include "includes.h"
 #include "vfs_posix.h"
 #include "librpc/gen_ndr/xattr.h"
+#include "lib/util/tsort.h"
 
 /*
   normalise a stream name, removing a :$DATA suffix if there is one 
@@ -51,7 +52,7 @@ static int stream_name_cmp(const char *name1, const char *name2)
        l1 = c1?(c1 - name1):strlen(name1);
        l2 = c2?(c2 - name2):strlen(name2);
        if (l1 != l2) {
-               return l1 - l2;
+               return NUMERIC_CMP(l1, l2);
        }
        ret = strncasecmp_m(name1, name2, l1);
        if (ret != 0) {