Insure we always return NULL on error.

It is not technically an ldb bug, but apparently some callers try to access
res before checking the ldb_search() return code.
So make their attempt very evident (a NULL dereference will make it cristal
clear where the bug is).
(cherry picked from commit c60539f31f63bd65e5b0e3ee16365f036bef3d5b)

diff --git a/source/lib/ldb/common/ldb.c b/source/lib/ldb/common/ldb.c
index 743711b9672ca73a482767a855c7dc9db439d2a6..c8aa6afdfc131cc08f9f6caf9f9081a5e709a112 100644 (file)
--- a/source/lib/ldb/common/ldb.c
+++ b/source/lib/ldb/common/ldb.c
@@ -787,6 +787,7 @@ int ldb_search(struct ldb_context *ldb,
 done:
        if (ret != LDB_SUCCESS) {
                talloc_free(res);
+               res = NULL;
        }
 
        *_res = res;