s3-net_conf: Display an error on net conf import failures.
authorJim McDonough <jmcd@samba.org>
Wed, 21 Apr 2010 18:53:51 +0000 (20:53 +0200)
committerKarolin Seeger <kseeger@samba.org>
Thu, 6 May 2010 12:08:39 +0000 (14:08 +0200)
When something goes wrong, such as a typo in a parameter
name, we'll now display the failure instead of just returning
with -1 and no message.

Fix bug #7378 ("net conf import" fails silently on parameter typo).
(cherry picked from commit d983085cee01fcf6e6176d395400075e6d5df937)

source3/utils/net_conf.c

index 1dd8c1fc10264c20aa516d7f2b6caabb3c16562e..e30c0abccf3472837d7498748b81b98cb0c5ab93 100644 (file)
@@ -209,6 +209,9 @@ static WERROR import_process_service(struct net_context *c,
                                                     service->param_names[idx],
                                                     service->param_values[idx]);
                        if (!W_ERROR_IS_OK(werr)) {
+                               d_printf("Error in section [%s], parameter \"%s\": %s\n",
+                                        service->name, service->param_names[idx],
+                                        win_errstr(werr));
                                goto done;
                        }
                }