s3:utils: Remove double error check
authorAndreas Schneider <asn@samba.org>
Wed, 23 May 2018 15:35:15 +0000 (17:35 +0200)
committerGünther Deschner <gd@samba.org>
Thu, 24 May 2018 16:07:03 +0000 (18:07 +0200)
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Thu May 24 18:07:03 CEST 2018 on sn-devel-144

source3/utils/net_dns.c

index 9ee856c00595b34f38c9f29c05df02f1ba481c6a..b94bef987a157e572d2e7649722299c812a8bb59 100644 (file)
@@ -96,10 +96,9 @@ DNS_ERROR DoDNSUpdate(char *pszServerName,
                if (!ERR_DNS_IS_OK(err)) goto error;
 
                err = dns_update_transaction(mem_ctx, conn, req, &resp);
-               if (!ERR_DNS_IS_OK(err)) goto error;
-
                if (!ERR_DNS_IS_OK(err)) {
                        DEBUG(3,("DoDNSUpdate: unsigned update failed\n"));
+                       goto error;
                }
 
                if ((dns_response_code(resp->flags) == DNS_NO_ERROR) &&