prevent segmentation fault on joining a very long domain name in samba-3.0.32

For a detailed explanation, see
http://lists.samba.org/archive/samba-technical/2009-March/063626.html

diff --git a/source/libads/cldap.c b/source/libads/cldap.c
index 3cb98c59c58ff801e737610fc511567fde8c04dc..e01b00bdd8022401d841d60ec33d2e0f25851a9a 100644 (file)
--- a/source/libads/cldap.c
+++ b/source/libads/cldap.c
@@ -60,7 +60,7 @@ static unsigned pull_netlogon_string(char *ret, const char *ptr,
                                ret_len += 2;
                                followed_ptr = 1;
                        }
-                       len = ((ptr[0] & 0x3f) << 8) | ptr[1];
+                       len = ((ptr[0] & 0x3f) << 8) | (uint8) ptr[1];
                        ptr = data + len;
                } else if (*ptr) {
                        uint8 len = (uint8)*(ptr++);