Streamline logic, reducing the amount of indentation.
authorMichael Adam <obnox@samba.org>
Fri, 19 Oct 2007 20:42:28 +0000 (22:42 +0200)
committerGerald (Jerry) Carter <jerry@samba.org>
Fri, 19 Oct 2007 20:54:23 +0000 (15:54 -0500)
Michael

source/rpc_server/srv_srvsvc_nt.c

index 27bc807367183966a9901e18acef6cd5bca91053..55c30c5315a545e619143779f5f3bf73cb3cbf96 100644 (file)
@@ -2033,22 +2033,21 @@ WERROR _srv_net_file_query_secdesc(pipes_struct *p, SRV_Q_NET_FILE_QUERY_SECDESC
        }
 
        nt_status = open_file_stat(conn, NULL, filename, &st, &fsp);
-       if ( !NT_STATUS_IS_OK(nt_status)) {
-               /* Perhaps it is a directory */
-               if (NT_STATUS_EQUAL(nt_status, NT_STATUS_FILE_IS_A_DIRECTORY))
-                       nt_status = open_directory(conn, NULL, filename, &st,
-                                       READ_CONTROL_ACCESS,
-                                       FILE_SHARE_READ|FILE_SHARE_WRITE,
-                                       FILE_OPEN,
-                                       0,
-                                       FILE_ATTRIBUTE_DIRECTORY,
-                                       NULL, &fsp);
-
-               if (!NT_STATUS_IS_OK(nt_status)) {
-                       DEBUG(3,("_srv_net_file_query_secdesc: Unable to open file %s\n", filename));
-                       r_u->status = ntstatus_to_werror(nt_status);
-                       goto error_exit;
-               }
+       /* Perhaps it is a directory */
+       if (NT_STATUS_EQUAL(nt_status, NT_STATUS_FILE_IS_A_DIRECTORY)) {
+               nt_status = open_directory(conn, NULL, filename, &st,
+                                          READ_CONTROL_ACCESS,
+                                          FILE_SHARE_READ|FILE_SHARE_WRITE,
+                                          FILE_OPEN,
+                                          0,
+                                          FILE_ATTRIBUTE_DIRECTORY,
+                                          NULL, &fsp);
+       }
+
+       if (!NT_STATUS_IS_OK(nt_status)) {
+               DEBUG(3,("_srv_net_file_query_secdesc: Unable to open file %s\n", filename));
+               r_u->status = ntstatus_to_werror(nt_status);
+               goto error_exit;
        }
 
        sd_size = SMB_VFS_GET_NT_ACL(fsp, fsp->fsp_name, (OWNER_SECURITY_INFORMATION|GROUP_SECURITY_INFORMATION|DACL_SECURITY_INFORMATION), &psd);