nfs4acls: Slightly simplify smb_add_ace4
authorVolker Lendecke <vl@samba.org>
Tue, 15 Aug 2017 04:02:13 +0000 (06:02 +0200)
committerVolker Lendecke <vl@samba.org>
Sun, 22 Oct 2017 15:46:15 +0000 (17:46 +0200)
The comment was a bit confusing to me, it took a few seconds too many to figure
out *why* setting NULL is not required. Remove it :-)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/modules/nfs4_acls.c

index 538517f4a3c16755a839a510ae3f55506d610128..19f0fefdb98e8a4215a948fb1e17a9b888b23272 100644 (file)
@@ -184,8 +184,7 @@ struct SMB4ACE_T *smb_add_ace4(struct SMB4ACL_T *acl, SMB_ACE4PROP_T *prop)
                errno = ENOMEM;
                return NULL;
        }
-       /* ace->next = NULL not needed */
-       memcpy(&ace->prop, prop, sizeof(SMB_ACE4PROP_T));
+       ace->prop = *prop;
 
        if (acl->first==NULL)
        {