winbind: Remove "lookup_usergroups" winbind method
authorVolker Lendecke <vl@samba.org>
Tue, 3 Jan 2017 15:21:37 +0000 (15:21 +0000)
committerVolker Lendecke <vl@samba.org>
Wed, 4 Jan 2017 11:22:12 +0000 (12:22 +0100)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/winbindd/winbindd.h
source3/winbindd/winbindd_ads.c
source3/winbindd/winbindd_msrpc.c
source3/winbindd/winbindd_reconnect.c
source3/winbindd/winbindd_reconnect_ads.c
source3/winbindd/winbindd_samr.c

index 155369f760c35bdc21284d30d9f95a67fa2a234d..3f28fd07a3cb36a9e66d6ffa05af879a95bc148c 100644 (file)
@@ -263,14 +263,6 @@ struct winbindd_methods {
                                  char ***names,
                                  enum lsa_SidType **types);
 
-       /* lookup all groups that a user is a member of. The backend
-          can also choose to lookup by username or rid for this
-          function */
-       NTSTATUS (*lookup_usergroups)(struct winbindd_domain *domain,
-                                     TALLOC_CTX *mem_ctx,
-                                     const struct dom_sid *user_sid,
-                                     uint32_t *num_groups, struct dom_sid **user_gids);
-
        /* Lookup all aliases that the sids delivered are member of. This is
         * to implement 'domain local groups' correctly */
        NTSTATUS (*lookup_useraliases)(struct winbindd_domain *domain,
index 7b8603c90925cf18b1fe2f111e166d9de35e2a3d..0f70334fe614cd11d4fa603811e54577cfdca676 100644 (file)
@@ -601,382 +601,6 @@ static NTSTATUS rids_to_names(struct winbindd_domain *domain,
                                           domain_name, names, types);
 }
 
-/* Lookup groups a user is a member of - alternate method, for when
-   tokenGroups are not available. */
-static NTSTATUS lookup_usergroups_member(struct winbindd_domain *domain,
-                                        TALLOC_CTX *mem_ctx,
-                                        const char *user_dn, 
-                                        struct dom_sid *primary_group,
-                                        uint32_t *p_num_groups, struct dom_sid **user_sids)
-{
-       ADS_STATUS rc;
-       NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
-       int count;
-       LDAPMessage *res = NULL;
-       LDAPMessage *msg = NULL;
-       char *ldap_exp;
-       ADS_STRUCT *ads;
-       const char *group_attrs[] = {"objectSid", NULL};
-       char *escaped_dn;
-       uint32_t num_groups = 0;
-
-       DEBUG(3,("ads: lookup_usergroups_member\n"));
-
-       if ( !winbindd_can_contact_domain( domain ) ) {
-               DEBUG(10,("lookup_usergroups_members: No incoming trust for domain %s\n",
-                         domain->name));               
-               return NT_STATUS_OK;
-       }
-
-       ads = ads_cached_connection(domain);
-
-       if (!ads) {
-               domain->last_status = NT_STATUS_SERVER_DISABLED;
-               goto done;
-       }
-
-       if (!(escaped_dn = escape_ldap_string(talloc_tos(), user_dn))) {
-               status = NT_STATUS_NO_MEMORY;
-               goto done;
-       }
-
-       ldap_exp = talloc_asprintf(mem_ctx,
-               "(&(member=%s)(objectCategory=group)(groupType:dn:%s:=%d))",
-               escaped_dn,
-               ADS_LDAP_MATCHING_RULE_BIT_AND,
-               GROUP_TYPE_SECURITY_ENABLED);
-       if (!ldap_exp) {
-               DEBUG(1,("lookup_usergroups(dn=%s) asprintf failed!\n", user_dn));
-               TALLOC_FREE(escaped_dn);
-               status = NT_STATUS_NO_MEMORY;
-               goto done;
-       }
-
-       TALLOC_FREE(escaped_dn);
-
-       rc = ads_search_retry(ads, &res, ldap_exp, group_attrs);
-
-       if (!ADS_ERR_OK(rc)) {
-               DEBUG(1,("lookup_usergroups ads_search member=%s: %s\n", user_dn, ads_errstr(rc)));
-               return ads_ntstatus(rc);
-       } else if (!res) {
-               DEBUG(1,("lookup_usergroups ads_search returned NULL res\n"));
-               return NT_STATUS_INTERNAL_ERROR;
-       }
-
-
-       count = ads_count_replies(ads, res);
-
-       *user_sids = NULL;
-       num_groups = 0;
-
-       /* always add the primary group to the sid array */
-       status = add_sid_to_array(mem_ctx, primary_group, user_sids,
-                                 &num_groups);
-       if (!NT_STATUS_IS_OK(status)) {
-               goto done;
-       }
-
-       if (count > 0) {
-               for (msg = ads_first_entry(ads, res); msg;
-                    msg = ads_next_entry(ads, msg)) {
-                       struct dom_sid group_sid;
-
-                       if (!ads_pull_sid(ads, msg, "objectSid", &group_sid)) {
-                               DEBUG(1,("No sid for this group ?!?\n"));
-                               continue;
-                       }
-
-                       /* ignore Builtin groups from ADS - Guenther */
-                       if (sid_check_is_in_builtin(&group_sid)) {
-                               continue;
-                       }
-
-                       status = add_sid_to_array(mem_ctx, &group_sid,
-                                                 user_sids, &num_groups);
-                       if (!NT_STATUS_IS_OK(status)) {
-                               goto done;
-                       }
-               }
-
-       }
-
-       *p_num_groups = num_groups;
-       status = (user_sids != NULL) ? NT_STATUS_OK : NT_STATUS_NO_MEMORY;
-
-       DEBUG(3,("ads lookup_usergroups (member) succeeded for dn=%s\n", user_dn));
-done:
-       if (res) 
-               ads_msgfree(ads, res);
-
-       return status;
-}
-
-/* Lookup groups a user is a member of - alternate method, for when
-   tokenGroups are not available. */
-static NTSTATUS lookup_usergroups_memberof(struct winbindd_domain *domain,
-                                          TALLOC_CTX *mem_ctx,
-                                          const char *user_dn,
-                                          struct dom_sid *primary_group,
-                                          uint32_t *p_num_groups,
-                                          struct dom_sid **user_sids)
-{
-       ADS_STATUS rc;
-       NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
-       ADS_STRUCT *ads;
-       const char *attrs[] = {"memberOf", NULL};
-       uint32_t num_groups = 0;
-       struct dom_sid *group_sids = NULL;
-       int i;
-       char **strings = NULL;
-       size_t num_strings = 0, num_sids = 0;
-
-
-       DEBUG(3,("ads: lookup_usergroups_memberof\n"));
-
-       if ( !winbindd_can_contact_domain( domain ) ) {
-               DEBUG(10,("lookup_usergroups_memberof: No incoming trust for "
-                         "domain %s\n", domain->name));
-               return NT_STATUS_OK;
-       }
-
-       ads = ads_cached_connection(domain);
-
-       if (!ads) {
-               domain->last_status = NT_STATUS_SERVER_DISABLED;
-               return NT_STATUS_UNSUCCESSFUL;
-       }
-
-       rc = ads_search_retry_extended_dn_ranged(ads, mem_ctx, user_dn, attrs,
-                                                ADS_EXTENDED_DN_HEX_STRING,
-                                                &strings, &num_strings);
-
-       if (!ADS_ERR_OK(rc)) {
-               DEBUG(1,("lookup_usergroups_memberof ads_search "
-                       "member=%s: %s\n", user_dn, ads_errstr(rc)));
-               return ads_ntstatus(rc);
-       }
-
-       *user_sids = NULL;
-       num_groups = 0;
-
-       /* always add the primary group to the sid array */
-       status = add_sid_to_array(mem_ctx, primary_group, user_sids,
-                                 &num_groups);
-       if (!NT_STATUS_IS_OK(status)) {
-               goto done;
-       }
-
-       group_sids = talloc_zero_array(mem_ctx, struct dom_sid, num_strings + 1);
-       if (!group_sids) {
-               status = NT_STATUS_NO_MEMORY;
-               goto done;
-       }
-
-       for (i=0; i<num_strings; i++) {
-               rc = ads_get_sid_from_extended_dn(mem_ctx, strings[i],
-                                                 ADS_EXTENDED_DN_HEX_STRING,
-                                                 &(group_sids)[i]);
-               if (!ADS_ERR_OK(rc)) {
-                       /* ignore members without SIDs */
-                       if (NT_STATUS_EQUAL(ads_ntstatus(rc),
-                           NT_STATUS_NOT_FOUND)) {
-                               continue;
-                       }
-                       else {
-                               status = ads_ntstatus(rc);
-                               goto done;
-                       }
-               }
-               num_sids++;
-       }
-
-       if (i == 0) {
-               DEBUG(1,("No memberOf for this user?!?\n"));
-               status = NT_STATUS_NO_MEMORY;
-               goto done;
-       }
-
-       for (i=0; i<num_sids; i++) {
-
-               /* ignore Builtin groups from ADS - Guenther */
-               if (sid_check_is_in_builtin(&group_sids[i])) {
-                       continue;
-               }
-
-               status = add_sid_to_array(mem_ctx, &group_sids[i], user_sids,
-                                         &num_groups);
-               if (!NT_STATUS_IS_OK(status)) {
-                       goto done;
-               }
-
-       }
-
-       *p_num_groups = num_groups;
-       status = (*user_sids != NULL) ? NT_STATUS_OK : NT_STATUS_NO_MEMORY;
-
-       DEBUG(3,("ads lookup_usergroups (memberof) succeeded for dn=%s\n",
-               user_dn));
-
-done:
-       TALLOC_FREE(strings);
-       TALLOC_FREE(group_sids);
-
-       return status;
-}
-
-
-/* Lookup groups a user is a member of. */
-static NTSTATUS lookup_usergroups(struct winbindd_domain *domain,
-                                 TALLOC_CTX *mem_ctx,
-                                 const struct dom_sid *sid,
-                                 uint32_t *p_num_groups, struct dom_sid **user_sids)
-{
-       ADS_STRUCT *ads = NULL;
-       const char *attrs[] = {"tokenGroups", "primaryGroupID", NULL};
-       ADS_STATUS rc;
-       int count;
-       LDAPMessage *msg = NULL;
-       char *user_dn = NULL;
-       struct dom_sid *sids;
-       int i;
-       struct dom_sid primary_group;
-       uint32_t primary_group_rid;
-       NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
-       uint32_t num_groups = 0;
-
-       DEBUG(3,("ads: lookup_usergroups\n"));
-       *p_num_groups = 0;
-
-       status = lookup_usergroups_cached(mem_ctx, sid,
-                                         p_num_groups, user_sids);
-       if (NT_STATUS_IS_OK(status)) {
-               return NT_STATUS_OK;
-       }
-
-       if ( !winbindd_can_contact_domain( domain ) ) {
-               DEBUG(10,("lookup_usergroups: No incoming trust for domain %s\n",
-                         domain->name));
-
-               /* Tell the cache manager not to remember this one */
-
-               return NT_STATUS_SYNCHRONIZATION_REQUIRED;
-       }
-
-       ads = ads_cached_connection(domain);
-
-       if (!ads) {
-               domain->last_status = NT_STATUS_SERVER_DISABLED;
-               status = NT_STATUS_SERVER_DISABLED;
-               goto done;
-       }
-
-       rc = ads_search_retry_sid(ads, &msg, sid, attrs);
-
-       if (!ADS_ERR_OK(rc)) {
-               status = ads_ntstatus(rc);
-               DEBUG(1, ("lookup_usergroups(sid=%s) ads_search tokenGroups: "
-                         "%s\n", sid_string_dbg(sid), ads_errstr(rc)));
-               goto done;
-       }
-
-       count = ads_count_replies(ads, msg);
-       if (count != 1) {
-               status = NT_STATUS_UNSUCCESSFUL;
-               DEBUG(1,("lookup_usergroups(sid=%s) ads_search tokenGroups: "
-                        "invalid number of results (count=%d)\n", 
-                        sid_string_dbg(sid), count));
-               goto done;
-       }
-
-       if (!msg) {
-               DEBUG(1,("lookup_usergroups(sid=%s) ads_search tokenGroups: NULL msg\n", 
-                        sid_string_dbg(sid)));
-               status = NT_STATUS_UNSUCCESSFUL;
-               goto done;
-       }
-
-       user_dn = ads_get_dn(ads, mem_ctx, msg);
-       if (user_dn == NULL) {
-               status = NT_STATUS_NO_MEMORY;
-               goto done;
-       }
-
-       if (!ads_pull_uint32(ads, msg, "primaryGroupID", &primary_group_rid)) {
-               DEBUG(1,("%s: No primary group for sid=%s !?\n", 
-                        domain->name, sid_string_dbg(sid)));
-               goto done;
-       }
-
-       sid_compose(&primary_group, &domain->sid, primary_group_rid);
-
-       count = ads_pull_sids(ads, mem_ctx, msg, "tokenGroups", &sids);
-
-       /* there must always be at least one group in the token, 
-          unless we are talking to a buggy Win2k server */
-
-       /* actually this only happens when the machine account has no read
-        * permissions on the tokenGroup attribute - gd */
-
-       if (count == 0) {
-
-               /* no tokenGroups */
-
-               /* lookup what groups this user is a member of by DN search on
-                * "memberOf" */
-
-               status = lookup_usergroups_memberof(domain, mem_ctx, user_dn,
-                                                   &primary_group,
-                                                   &num_groups, user_sids);
-               *p_num_groups = num_groups;
-               if (NT_STATUS_IS_OK(status)) {
-                       goto done;
-               }
-
-               /* lookup what groups this user is a member of by DN search on
-                * "member" */
-
-               status = lookup_usergroups_member(domain, mem_ctx, user_dn, 
-                                                 &primary_group,
-                                                 &num_groups, user_sids);
-               *p_num_groups = num_groups;
-               goto done;
-       }
-
-       *user_sids = NULL;
-       num_groups = 0;
-
-       status = add_sid_to_array(mem_ctx, &primary_group, user_sids,
-                                 &num_groups);
-       if (!NT_STATUS_IS_OK(status)) {
-               goto done;
-       }
-
-       for (i=0;i<count;i++) {
-
-               /* ignore Builtin groups from ADS - Guenther */
-               if (sid_check_is_in_builtin(&sids[i])) {
-                       continue;
-               }
-
-               status = add_sid_to_array_unique(mem_ctx, &sids[i],
-                                                user_sids, &num_groups);
-               if (!NT_STATUS_IS_OK(status)) {
-                       goto done;
-               }
-       }
-
-       *p_num_groups = (uint32_t)num_groups;
-       status = (*user_sids != NULL) ? NT_STATUS_OK : NT_STATUS_NO_MEMORY;
-
-       DEBUG(3,("ads lookup_usergroups (tokenGroups) succeeded for sid=%s\n",
-                sid_string_dbg(sid)));
-done:
-       TALLOC_FREE(user_dn);
-       ads_msgfree(ads, msg);
-       return status;
-}
-
 /* Lookup aliases a user is member of - use rpc methods */
 static NTSTATUS lookup_useraliases(struct winbindd_domain *domain,
                                   TALLOC_CTX *mem_ctx,
@@ -1552,7 +1176,6 @@ struct winbindd_methods ads_methods = {
        name_to_sid,
        sid_to_name,
        rids_to_names,
-       lookup_usergroups,
        lookup_useraliases,
        lookup_groupmem,
        sequence_number,
index 1aa162c5a10509f6534374be65ab45b9fd69b8a1..bc19973082d99fefee2c6be2a51524af0e56fe46 100644 (file)
@@ -403,77 +403,6 @@ static NTSTATUS msrpc_rids_to_names(struct winbindd_domain *domain,
        return result;
 }
 
-/* Lookup groups a user is a member of.  I wish Unix had a call like this! */
-static NTSTATUS msrpc_lookup_usergroups(struct winbindd_domain *domain,
-                                       TALLOC_CTX *mem_ctx,
-                                       const struct dom_sid *user_sid,
-                                       uint32_t *pnum_groups,
-                                       struct dom_sid **puser_grpsids)
-{
-       struct rpc_pipe_client *samr_pipe;
-       struct policy_handle dom_pol;
-       struct dom_sid *user_grpsids = NULL;
-       uint32_t num_groups = 0;
-       TALLOC_CTX *tmp_ctx;
-       NTSTATUS status;
-
-       DEBUG(3,("msrpc_lookup_usergroups sid=%s\n", sid_string_dbg(user_sid)));
-
-       *pnum_groups = 0;
-
-       tmp_ctx = talloc_stackframe();
-       if (tmp_ctx == NULL) {
-               return NT_STATUS_NO_MEMORY;
-       }
-
-       /* Check if we have a cached user_info_3 */
-       status = lookup_usergroups_cached(tmp_ctx,
-                                         user_sid,
-                                         &num_groups,
-                                         &user_grpsids);
-       if (NT_STATUS_IS_OK(status)) {
-               goto cached;
-       }
-
-       if ( !winbindd_can_contact_domain( domain ) ) {
-               DEBUG(10,("lookup_usergroups: No incoming trust for domain %s\n",
-                         domain->name));
-
-               /* Tell the cache manager not to remember this one */
-               status = NT_STATUS_SYNCHRONIZATION_REQUIRED;
-               goto done;
-       }
-
-       /* no cache; hit the wire */
-       status = cm_connect_sam(domain, tmp_ctx, false, &samr_pipe, &dom_pol);
-       if (!NT_STATUS_IS_OK(status)) {
-               goto done;
-       }
-
-       status = rpc_lookup_usergroups(tmp_ctx,
-                                      samr_pipe,
-                                      &dom_pol,
-                                      &domain->sid,
-                                      user_sid,
-                                      &num_groups,
-                                      &user_grpsids);
-       if (!NT_STATUS_IS_OK(status)) {
-               goto done;
-       }
-
-cached:
-       *pnum_groups = num_groups;
-
-       if (puser_grpsids) {
-               *puser_grpsids = talloc_move(mem_ctx, &user_grpsids);
-       }
-
-done:
-       TALLOC_FREE(tmp_ctx);
-       return status;
-       return NT_STATUS_OK;
-}
-
 #define MAX_SAM_ENTRIES_W2K 0x400 /* 1024 */
 
 static NTSTATUS msrpc_lookup_useraliases(struct winbindd_domain *domain,
@@ -1171,7 +1100,6 @@ struct winbindd_methods msrpc_methods = {
        msrpc_name_to_sid,
        msrpc_sid_to_name,
        msrpc_rids_to_names,
-       msrpc_lookup_usergroups,
        msrpc_lookup_useraliases,
        msrpc_lookup_groupmem,
        msrpc_sequence_number,
index 0406c995b1b79234134b5d0fe219779bbadb5f7f..5727a653e3eb15dfda757c42e2211aa513766d56 100644 (file)
@@ -201,26 +201,6 @@ static NTSTATUS rids_to_names(struct winbindd_domain *domain,
        return result;
 }
 
-/* Lookup groups a user is a member of.  I wish Unix had a call like this! */
-static NTSTATUS lookup_usergroups(struct winbindd_domain *domain,
-                                 TALLOC_CTX *mem_ctx,
-                                 const struct dom_sid *user_sid,
-                                 uint32_t *num_groups, struct dom_sid **user_gids)
-{
-       NTSTATUS result;
-
-       result = msrpc_methods.lookup_usergroups(domain, mem_ctx,
-                                                user_sid, num_groups,
-                                                user_gids);
-
-       if (reconnect_need_retry(result, domain))
-               result = msrpc_methods.lookup_usergroups(domain, mem_ctx,
-                                                        user_sid, num_groups,
-                                                        user_gids);
-
-       return result;
-}
-
 static NTSTATUS lookup_useraliases(struct winbindd_domain *domain,
                                   TALLOC_CTX *mem_ctx,
                                   uint32_t num_sids, const struct dom_sid *sids,
@@ -336,7 +316,6 @@ struct winbindd_methods reconnect_methods = {
        name_to_sid,
        sid_to_name,
        rids_to_names,
-       lookup_usergroups,
        lookup_useraliases,
        lookup_groupmem,
        sequence_number,
index 5a91360747204f4f05111a0b0f9edc84bd9d4131..dbfa7ff16d3f2c3bf3c1e431166ab70ab7dba43a 100644 (file)
@@ -156,27 +156,6 @@ static NTSTATUS rids_to_names(struct winbindd_domain *domain,
        return result;
 }
 
-/* Lookup groups a user is a member of.  I wish Unix had a call like this! */
-static NTSTATUS lookup_usergroups(struct winbindd_domain *domain,
-                                 TALLOC_CTX *mem_ctx,
-                                 const struct dom_sid *user_sid,
-                                 uint32_t *num_groups,
-                                 struct dom_sid **user_gids)
-{
-       NTSTATUS result;
-
-       result = ads_methods.lookup_usergroups(domain, mem_ctx, user_sid,
-                                              num_groups, user_gids);
-
-       if (reconnect_need_retry(result, domain)) {
-               result = ads_methods.lookup_usergroups(domain, mem_ctx,
-                                                      user_sid, num_groups,
-                                                      user_gids);
-       }
-
-       return result;
-}
-
 static NTSTATUS lookup_useraliases(struct winbindd_domain *domain,
                                   TALLOC_CTX *mem_ctx,
                                   uint32_t num_sids,
@@ -293,7 +272,6 @@ struct winbindd_methods reconnect_ads_methods = {
        name_to_sid,
        sid_to_name,
        rids_to_names,
-       lookup_usergroups,
        lookup_useraliases,
        lookup_groupmem,
        sequence_number,
index 0ce98ab542a1c8283eeb029c23989d42a66d8f23..419e328ba287646f374c38bb11483534e4aae8a3 100644 (file)
@@ -790,69 +790,6 @@ error:
        return status;
 }
 
-/* Lookup groups a user is a member of. */
-static NTSTATUS sam_lookup_usergroups(struct winbindd_domain *domain,
-                                     TALLOC_CTX *mem_ctx,
-                                     const struct dom_sid *user_sid,
-                                     uint32_t *pnum_groups,
-                                     struct dom_sid **puser_grpsids)
-{
-       struct rpc_pipe_client *samr_pipe;
-       struct policy_handle dom_pol;
-       struct dom_sid *user_grpsids = NULL;
-       uint32_t num_groups = 0;
-       TALLOC_CTX *tmp_ctx;
-       NTSTATUS status, result;
-       struct dcerpc_binding_handle *b = NULL;
-
-       DEBUG(3,("sam_lookup_usergroups\n"));
-
-       ZERO_STRUCT(dom_pol);
-
-       if (pnum_groups) {
-               *pnum_groups = 0;
-       }
-
-       tmp_ctx = talloc_stackframe();
-       if (tmp_ctx == NULL) {
-               return NT_STATUS_NO_MEMORY;
-       }
-
-       status = open_internal_samr_conn(tmp_ctx, domain, &samr_pipe, &dom_pol);
-       if (!NT_STATUS_IS_OK(status)) {
-               goto done;
-       }
-
-       b = samr_pipe->binding_handle;
-
-       status = rpc_lookup_usergroups(tmp_ctx,
-                                      samr_pipe,
-                                      &dom_pol,
-                                      &domain->sid,
-                                      user_sid,
-                                      &num_groups,
-                                      &user_grpsids);
-       if (!NT_STATUS_IS_OK(status)) {
-               goto done;
-       }
-
-       if (pnum_groups) {
-               *pnum_groups = num_groups;
-       }
-
-       if (puser_grpsids) {
-               *puser_grpsids = talloc_move(mem_ctx, &user_grpsids);
-       }
-
-done:
-       if (b && is_valid_policy_hnd(&dom_pol)) {
-               dcerpc_samr_Close(b, mem_ctx, &dom_pol, &result);
-       }
-
-       TALLOC_FREE(tmp_ctx);
-       return status;
-}
-
 static NTSTATUS sam_lookup_useraliases(struct winbindd_domain *domain,
                                       TALLOC_CTX *mem_ctx,
                                       uint32_t num_sids,
@@ -978,7 +915,6 @@ struct winbindd_methods builtin_passdb_methods = {
        .name_to_sid           = sam_name_to_sid,
        .sid_to_name           = sam_sid_to_name,
        .rids_to_names         = sam_rids_to_names,
-       .lookup_usergroups     = sam_lookup_usergroups,
        .lookup_useraliases    = sam_lookup_useraliases,
        .lookup_groupmem       = sam_lookup_groupmem,
        .sequence_number       = sam_sequence_number,
@@ -997,7 +933,6 @@ struct winbindd_methods sam_passdb_methods = {
        .name_to_sid           = sam_name_to_sid,
        .sid_to_name           = sam_sid_to_name,
        .rids_to_names         = sam_rids_to_names,
-       .lookup_usergroups     = sam_lookup_usergroups,
        .lookup_useraliases    = sam_lookup_useraliases,
        .lookup_groupmem       = sam_lookup_groupmem,
        .sequence_number       = sam_sequence_number,