gpo: Ensure all files are retrieved in fetch
authorGarming Sam <garming@catalyst.net.nz>
Wed, 9 May 2018 03:24:38 +0000 (15:24 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Sat, 12 May 2018 00:09:29 +0000 (02:09 +0200)
.ini files are normally set as hidden, and will not be found over SMB.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/netcmd/gpo.py

index cd946d9fa72cf64834c42e32c3ad95991f035361..425627287919d518e3fd362ef5d1ac88d014e4d5 100644 (file)
@@ -231,6 +231,10 @@ def parse_unc(unc):
         return tmp
     raise ValueError("Invalid UNC string: %s" % unc)
 
+attr_flags = smb.FILE_ATTRIBUTE_SYSTEM | \
+             smb.FILE_ATTRIBUTE_DIRECTORY | \
+             smb.FILE_ATTRIBUTE_ARCHIVE | \
+             smb.FILE_ATTRIBUTE_HIDDEN
 
 def copy_directory_remote_to_local(conn, remotedir, localdir):
     if not os.path.isdir(localdir):
@@ -241,7 +245,7 @@ def copy_directory_remote_to_local(conn, remotedir, localdir):
         r_dir = r_dirs.pop()
         l_dir = l_dirs.pop()
 
-        dirlist = conn.list(r_dir)
+        dirlist = conn.list(r_dir, attribs=attr_flags)
         for e in dirlist:
             r_name = r_dir + '\\' + e['name']
             l_name = os.path.join(l_dir, e['name'])