Fix winbindd coredump. Remember to set a ** pointer to null before

searching and not finding otherwise we return a valid looking pointer
that was whatever crap was on the stack.
Jeremy.

diff --git a/source/nsswitch/winbindd_cm.c b/source/nsswitch/winbindd_cm.c
index dbcfdcf88f9887c7261e714101c75be8f0bcb757..02fd15e06917afc5b7ca9d427d0a0dc5046c1536 100644 (file)
--- a/source/nsswitch/winbindd_cm.c
+++ b/source/nsswitch/winbindd_cm.c
@@ -450,6 +450,8 @@ static NTSTATUS get_connection_from_cache(const char *domain, const char *pipe_n
        struct winbindd_cm_conn *conn, conn_temp;
        NTSTATUS result;
 
+       *conn_out = NULL;
+
        for (conn = cm_conns; conn; conn = conn->next) {
                if (strequal(conn->domain, domain) && 
                    strequal(conn->pipe_name, pipe_name)) {

diff --git a/source/smbd/connection.c b/source/smbd/connection.c
index 5547309a818591d24401bd36889640b9ba8a199d..c2718d4d7035908234f5ecf446f4a3db601fe782 100644 (file)
--- a/source/smbd/connection.c
+++ b/source/smbd/connection.c
@@ -38,6 +38,7 @@ TDB_CONTEXT *conn_tdb_ctx(void)
 static void make_conn_key(connection_struct *conn, const char *name, TDB_DATA *pkbuf, struct connections_key *pkey)
 {
        ZERO_STRUCTP(pkey);
+       ZERO_STRUCTP(pkbuf);
        pkey->pid = sys_getpid();
        pkey->cnum = conn?conn->cnum:-1;
        fstrcpy(pkey->name, name);