cli_netlogon: Remove an unnecessary if-condition
authorVolker Lendecke <vl@samba.org>
Tue, 5 Sep 2017 14:26:11 +0000 (16:26 +0200)
committerVolker Lendecke <vl@samba.org>
Mon, 25 Sep 2017 07:43:11 +0000 (09:43 +0200)
We don't need to check this here. rpccli_create_netlogon_creds_ctx via
netlogon_creds_cli_context_global returns NT_STATUS_INVALID_PARAMETER for an
unknown schannel type. Slightly different error code, but we could change the
one in netlogon_creds_cli_context_global if necessary.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source3/rpc_client/cli_netlogon.c

index 4b8beb5f44f7f61497ffb64fef8658230ad0e64a..752a1574919e70c1e32b119d0f76dbb0f077d558 100644 (file)
@@ -140,10 +140,6 @@ NTSTATUS rpccli_create_netlogon_creds_ctx(
        const char *client_account;
 
        sec_chan_type = cli_credentials_get_secure_channel_type(creds);
-       if (sec_chan_type == SEC_CHAN_NULL) {
-               return NT_STATUS_INVALID_PARAMETER_MIX;
-       }
-
        client_account = cli_credentials_get_username(creds);
        server_netbios_domain = cli_credentials_get_domain(creds);
        server_dns_domain = cli_credentials_get_realm(creds);