git.samba.org
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
1854e6a
)
Fix bug #8644 - vfs_acl_xattr and vfs_acl_tdb modules can fail to add inheritable...
author
Jeremy Allison
<jra@samba.org>
Fri, 2 Dec 2011 18:55:40 +0000
(10:55 -0800)
committer
Karolin Seeger
<kseeger@samba.org>
Wed, 4 Jan 2012 20:10:53 +0000
(21:10 +0100)
If referring to an fsp sbuf can be left as an uninitialized variable,
causing the 'is_directory' variable to be false when it should be true.
(cherry picked from commit
16c0d52842386fc2ebf975166b57b888d36796c5
)
source3/modules/vfs_acl_common.c
patch
|
blob
|
history
diff --git
a/source3/modules/vfs_acl_common.c
b/source3/modules/vfs_acl_common.c
index ecc889a60d6978911915571f7b32ad176c80a730..e8c79e6eab1216528948933eafcdee7ad8586c97 100644
(file)
--- a/
source3/modules/vfs_acl_common.c
+++ b/
source3/modules/vfs_acl_common.c
@@
-373,7
+373,7
@@
static NTSTATUS get_nt_acl_internal(vfs_handle_struct *handle,
return map_nt_error_from_unix(errno);
}
}
- is_directory = S_ISDIR(
sbuf.
st_ex_mode);
+ is_directory = S_ISDIR(
psbuf->
st_ex_mode);
if (ignore_file_system_acl) {
TALLOC_FREE(pdesc_next);