Fix bug reported by David Eisner <deisner@gmail.com>. When allocating cli
authorJeremy Allison <jra@samba.org>
Tue, 3 Jun 2008 01:36:31 +0000 (18:36 -0700)
committerJeremy Allison <jra@samba.org>
Tue, 3 Jun 2008 01:36:31 +0000 (18:36 -0700)
buffers for large read/write - make sure we take account of the large
read/write SMB headers as well as the buffer space.
Jeremy.

source/libsmb/cliconnect.c

index c4671916ec44c879fb20dfe36f7af600270c71f5..b2425e32ec73d677aaa29a828bb7496900f0355f 100644 (file)
@@ -1330,9 +1330,9 @@ BOOL cli_negprot(struct cli_state *cli)
                if (cli->capabilities & (CAP_LARGE_READX|CAP_LARGE_WRITEX)) {
                        SAFE_FREE(cli->outbuf);
                        SAFE_FREE(cli->inbuf);
-                       cli->outbuf = (char *)SMB_MALLOC(CLI_SAMBA_MAX_LARGE_READX_SIZE+SAFETY_MARGIN);
-                       cli->inbuf = (char *)SMB_MALLOC(CLI_SAMBA_MAX_LARGE_READX_SIZE+SAFETY_MARGIN);
-                       cli->bufsize = CLI_SAMBA_MAX_LARGE_READX_SIZE;
+                       cli->outbuf = (char *)SMB_MALLOC(CLI_SAMBA_MAX_LARGE_READX_SIZE+LARGE_WRITEX_HDR_SIZE+SAFETY_MARGIN);
+                       cli->inbuf = (char *)SMB_MALLOC(CLI_SAMBA_MAX_LARGE_READX_SIZE+LARGE_WRITEX_HDR_SIZE+SAFETY_MARGIN);
+                       cli->bufsize = CLI_SAMBA_MAX_LARGE_READX_SIZE + LARGE_WRITEX_HDR_SIZE;
                }
 
        } else if (cli->protocol >= PROTOCOL_LANMAN1) {