git.samba.org
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
165e252
)
s3:rpc_transport_np: add comment about bad usage in a destructor
author
Stefan Metzmacher
<metze@samba.org>
Thu, 25 Mar 2010 13:10:25 +0000
(14:10 +0100)
committer
Karolin Seeger
<kseeger@samba.org>
Tue, 30 Mar 2010 08:33:41 +0000
(10:33 +0200)
metze
(cherry picked from commit
5f8fc63515a02aaf55719cb8d3be8ce695178fe9
)
(cherry picked from commit
8d576661d15f1c032a4fe17ed03bfeb376039bdb
)
source3/rpc_client/rpc_transport_np.c
patch
|
blob
|
history
diff --git
a/source3/rpc_client/rpc_transport_np.c
b/source3/rpc_client/rpc_transport_np.c
index 7ac0fa106eb1bd9a345b1200327d3942a8cc9b11..014ce92adccacaf037944e42a31d1ab92b82bc91 100644
(file)
--- a/
source3/rpc_client/rpc_transport_np.c
+++ b/
source3/rpc_client/rpc_transport_np.c
@@
-34,7
+34,8
@@
static int rpc_transport_np_state_destructor(struct rpc_transport_np_state *s)
DEBUG(10, ("socket was closed, no need to send close request.\n"));
return 0;
}
-
+
+ /* TODO: do not use a sync call with a destructor!!! */
if (!NT_STATUS_IS_OK(cli_close(s->cli, s->fnum))) {
DEBUG(1, ("rpc_transport_np_state_destructor: cli_close "
"failed on pipe %s. Error was %s\n", s->pipe_name,