s3:smbcontrol: Simplify the return code check

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Oct 20 02:17:56 CEST 2018 on sn-devel-144

diff --git a/source3/utils/smbcontrol.c b/source3/utils/smbcontrol.c
index e23e1284012d63e37f7767d9db89ab8785dbc952..597bab6450dd7ae8246c706da1960ea2721baed0 100644 (file)
--- a/source3/utils/smbcontrol.c
+++ b/source3/utils/smbcontrol.c
@@ -1142,14 +1142,13 @@ static bool do_winbind_offline(struct tevent_context *ev_ctx,
 
                /* Check that the entry "WINBINDD_OFFLINE" still exists. */
                d = tdb_fetch_bystring( tdb, "WINBINDD_OFFLINE" );
-
-               if (!d.dptr || d.dsize != 4) {
-                       SAFE_FREE(d.dptr);
-                       DEBUG(10,("do_winbind_offline: offline state not set - retrying.\n"));
-               } else {
+               if (d.dptr != NULL && d.dsize == 4) {
                        SAFE_FREE(d.dptr);
                        break;
                }
+
+               SAFE_FREE(d.dptr);
+               DEBUG(10,("do_winbind_offline: offline state not set - retrying.\n"));
        }
 
        tdb_close(tdb);