dcerpc/dns_server tests: use record malformed as probably intended
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Wed, 22 Aug 2018 05:11:45 +0000 (17:11 +1200)
committerDouglas Bagnall <dbagnall@samba.org>
Fri, 24 Aug 2018 05:49:32 +0000 (07:49 +0200)
Both ways the record is malformed, but it is more likely we meant
AAAAAAAAAA... 1
than
A 1A 1A 1A 1A ...

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/tests/dcerpc/dnsserver.py

index e63eccb6332320b06199cd59e6e34f185f331d03..8e485c540ddd44da20d7e0a05c9285380032c14f 100644 (file)
@@ -104,7 +104,7 @@ class DnsserverTests(RpcInterfaceTestCase):
         # actually create these records.
         invalid_mx = ["SAMDOM.EXAMPLE.COM -1",
                       "SAMDOM.EXAMPLE.COM 65536",
-                      "%s 1" % "A" *256]
+                      "%s 1" % ("A" * 256)]
         invalid_srv = ["SAMDOM.EXAMPLE.COM 0 65536 0",
                        "SAMDOM.EXAMPLE.COM 0 0 65536",
                        "SAMDOM.EXAMPLE.COM 65536 0 0"]