ctdb-common: Fix signed/unsigned comparisons by declaring as unsigned

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

diff --git a/ctdb/common/ctdb_ltdb.c b/ctdb/common/ctdb_ltdb.c
index 1fc9ce28c1b436e259ab4a1b53ad258d45922923..73458754def006d2d2ed51d9a404abc4812f281a 100644 (file)
--- a/ctdb/common/ctdb_ltdb.c
+++ b/ctdb/common/ctdb_ltdb.c
@@ -308,8 +308,8 @@ int ctdb_ltdb_delete(struct ctdb_db_context *ctdb_db, TDB_DATA key)
 
 int ctdb_trackingdb_add_pnn(struct ctdb_context *ctdb, TDB_DATA *data, uint32_t pnn)
 {
-       int byte_pos = pnn / 8;
-       int bit_mask   = 1 << (pnn % 8);
+       unsigned int byte_pos = pnn / 8;
+       unsigned char bit_mask = 1 << (pnn % 8);
 
        if (byte_pos + 1 > data->dsize) {
                char *buf;
@@ -334,10 +334,10 @@ int ctdb_trackingdb_add_pnn(struct ctdb_context *ctdb, TDB_DATA *data, uint32_t
 
 void ctdb_trackingdb_traverse(struct ctdb_context *ctdb, TDB_DATA data, ctdb_trackingdb_cb cb, void *private_data)
 {
-       int i;
+       unsigned int i;
 
        for(i = 0; i < data.dsize; i++) {
-               int j;
+               unsigned int j;
 
                for (j=0; j<8; j++) {
                        int mask = 1<<j;

diff --git a/ctdb/common/run_event.c b/ctdb/common/run_event.c
index ca4e572a80611a6163fc51278ece08ae743854e9..d283664e2cfac47d0a1bdbf4af3fa849f24fc5d7 100644 (file)
--- a/ctdb/common/run_event.c
+++ b/ctdb/common/run_event.c
@@ -519,7 +519,7 @@ struct run_event_state {
        struct run_event_script_list *script_list;
        const char **argv;
        struct tevent_req *script_subreq;
-       int index;
+       unsigned int index;
        bool cancelled;
 };