libnmb: Fix CID 1428474 Incorrect expression (COPY_PASTE_ERROR)
authorVolker Lendecke <vl@samba.org>
Wed, 24 Jan 2018 11:57:43 +0000 (12:57 +0100)
committerVolker Lendecke <vl@samba.org>
Thu, 25 Jan 2018 00:53:53 +0000 (01:53 +0100)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Jan 25 01:53:53 CET 2018 on sn-devel-144

source3/libsmb/nmblib.c

index bac43400b3a53d8a037bb249e423f709d11cc1f4..5bfc129ebf53a8099c3f3cc91167a503713053ec 100644 (file)
@@ -840,7 +840,7 @@ static struct packet_struct *copy_packet_talloc(
                        ndst->additional = talloc_memdup(
                                pkt, nsrc->additional,
                                sizeof(struct res_rec) * nsrc->header.arcount);
-                       if (ndst->nsrecs == NULL) {
+                       if (ndst->additional == NULL) {
                                goto fail;
                        }
                }