provision: Move default handler for site=None down into dc_join object creation
authorAndrew Bartlett <abartlet@samba.org>
Tue, 6 Jun 2017 03:21:50 +0000 (15:21 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Sat, 10 Jun 2017 19:48:21 +0000 (21:48 +0200)
This makes this code easier to call from a test script

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
python/samba/join.py
python/samba/netcmd/domain.py

index 3e70db08d2ad826deaa92b2e89fb214cbf5f72f5..681275cd72ddd102b246b7c801387b4b7abe65b5 100644 (file)
@@ -53,6 +53,9 @@ class dc_join(object):
                  netbios_name=None, targetdir=None, domain=None,
                  machinepass=None, use_ntvfs=False, dns_backend=None,
                  promote_existing=False, clone_only=False):
+        if site is None:
+            site = "Default-First-Site-Name"
+
         ctx.clone_only=clone_only
 
         ctx.logger = logger
index 4bd99ba6ff5c8b2dedbdd3a36e6e4ca876900854..e3a0e4921f26af09a14c201da20c0ef5e7f0c98b 100644 (file)
@@ -551,9 +551,6 @@ class cmd_domain_dcpromo(Command):
         creds = credopts.get_credentials(lp)
         net = Net(creds, lp, server=credopts.ipaddress)
 
-        if site is None:
-            site = "Default-First-Site-Name"
-
         logger = self.get_logger()
         if verbose:
             logger.setLevel(logging.DEBUG)