ctdbd_conn: fix a resource leak
authorRalph Boehme <slow@samba.org>
Tue, 27 Dec 2016 08:19:16 +0000 (09:19 +0100)
committerDavid Disseldorp <ddiss@samba.org>
Wed, 28 Dec 2016 00:29:21 +0000 (01:29 +0100)
When reinitializing the ctdb messaging subsystem we must free the ctdb
connection fde.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12485

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
source3/lib/messages_ctdbd.c

index 5964894323ec3163b87c7a7f62ba2ce57878284b..bee268500db79461e40a8c74c3bd4217441f131d 100644 (file)
@@ -183,6 +183,8 @@ static int messaging_ctdbd_init_internal(struct messaging_context *msg_ctx,
        int ret, ctdb_fd;
 
        if (reinit) {
+               TALLOC_FREE(ctx->fde);
+
                ret = ctdbd_reinit_connection(ctx,
                                              lp_ctdbd_socket(),
                                              lp_ctdb_timeout(),