lib: Remove unused sid_blob_parse

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/libcli/security/dom_sid.h b/libcli/security/dom_sid.h
index 86bbbdf0398aee725c10e34bb765f746598e50d7..990a4c491d3385669a7beb249f537b812e3563cc 100644 (file)
--- a/libcli/security/dom_sid.h
+++ b/libcli/security/dom_sid.h
@@ -93,7 +93,6 @@ bool sid_split_rid(struct dom_sid *sid, uint32_t *rid);
 bool sid_peek_rid(const struct dom_sid *sid, uint32_t *rid);
 bool sid_peek_check_rid(const struct dom_sid *exp_dom_sid, const struct dom_sid *sid, uint32_t *rid);
 void sid_copy(struct dom_sid *dst, const struct dom_sid *src);
-bool sid_blob_parse(DATA_BLOB in, struct dom_sid *sid);
 bool sid_parse(const uint8_t *inbuf, size_t len, struct dom_sid *sid);
 int sid_compare_domain(const struct dom_sid *sid1, const struct dom_sid *sid2);
 NTSTATUS add_sid_to_array(TALLOC_CTX *mem_ctx, const struct dom_sid *sid,

diff --git a/libcli/security/util_sid.c b/libcli/security/util_sid.c
index 7f628562123a4b0e49966b28c5dbcd0e01b62055..339980187320266c9fe1682c66be88688a936d83 100644 (file)
--- a/libcli/security/util_sid.c
+++ b/libcli/security/util_sid.c
@@ -254,30 +254,22 @@ void sid_copy(struct dom_sid *dst, const struct dom_sid *src)
 }
 
 /*****************************************************************
- Parse a on-the-wire SID (in a DATA_BLOB) to a struct dom_sid.
+ Parse a on-the-wire SID to a struct dom_sid.
 *****************************************************************/
 
-bool sid_blob_parse(DATA_BLOB in, struct dom_sid *sid)
+bool sid_parse(const uint8_t *inbuf, size_t len, struct dom_sid *sid)
 {
+       DATA_BLOB in = data_blob_const(inbuf, len);
        enum ndr_err_code ndr_err;
-       ndr_err = ndr_pull_struct_blob_all(&in, NULL, sid,
-                                          (ndr_pull_flags_fn_t)ndr_pull_dom_sid);
+
+       ndr_err = ndr_pull_struct_blob_all(
+               &in, NULL, sid, (ndr_pull_flags_fn_t)ndr_pull_dom_sid);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                return false;
        }
        return true;
 }
 
-/*****************************************************************
- Parse a on-the-wire SID to a struct dom_sid.
-*****************************************************************/
-
-bool sid_parse(const uint8_t *inbuf, size_t len, struct dom_sid *sid)
-{
-       DATA_BLOB in = data_blob_const(inbuf, len);
-       return sid_blob_parse(in, sid);
-}
-
 /*****************************************************************
  See if 2 SIDs are in the same domain
  this just compares the leading sub-auths