s4/scripting/get-descriptors: print usage with insufficient arguments

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/selftest/knownfail.d/usage b/selftest/knownfail.d/usage
index 6aba087dd2249b8d433f00694643d8b07b5a51af..193e1bbb7c50569ba5cdc77951cabcd3347928b4 100644 (file)
--- a/selftest/knownfail.d/usage
+++ b/selftest/knownfail.d/usage
@@ -1,7 +1,6 @@
 samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_chgtdcpass.none.
 samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_demodirsync_py.none.
 samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_findprovisionusnranges.none.
-samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_get_descriptors.none.
 samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_mymachinepw.none.
 samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_rebuildextendeddn.none.
 samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_renamedc.none.

diff --git a/source4/scripting/bin/get-descriptors b/source4/scripting/bin/get-descriptors
index 31106d434b07301b1bd7d4bd9c82a95f5780eee5..bed01e7ceb39daf104e8ebcd279247ae4cb07afc 100755 (executable)
--- a/source4/scripting/bin/get-descriptors
+++ b/source4/scripting/bin/get-descriptors
@@ -61,6 +61,10 @@ creds = credopts.get_credentials(lp)
 
 opts = parser.parse_args()[0]
 
+if not opts.host or not opts.localdomain or not opts.remote_domain:
+    parser.print_usage()
+    sys.exit(1)
+
 class DescrGetter:
 
     def __init__(self, localdomain, remotedomain):