dsdb group_audit tests: fix use of strncmp

Replace the uses of:
   strncmp(expected, value, strlen(expected))
With:
    strcmp(expected, value)

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c b/source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c
index 6ec218beb54e8db3037e9c1ad62cdff3a3dd75e8..241c0534dae0feb8e5f1486d55012a29a9c66c5b 100644 (file)
--- a/source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c
+++ b/source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c
@@ -113,6 +113,8 @@ static void _check_group_change_message(
        json_t *audit = NULL;
        json_t *v = NULL;
        const char* value;
+       int cmp;
+
        json = messages[message];
 
        /*
@@ -137,7 +139,8 @@ static void _check_group_change_message(
        }
 
        value = json_string_value(v);
-       if (strncmp("groupChange", value, strlen("groupChange") != 0)) {
+       cmp = strcmp("groupChange", value);
+       if (cmp != 0) {
                cm_print_error(
                    "Unexpected type \"%s\" != \"groupChange\"\n",
                    value);
@@ -172,7 +175,8 @@ static void _check_group_change_message(
        }
 
        value = json_string_value(v);
-       if (strncmp(user, value, strlen(user) != 0)) {
+       cmp = strcmp(user, value);
+       if (cmp != 0) {
                cm_print_error(
                    "Unexpected user name \"%s\" != \"%s\"\n",
                    value,
@@ -190,7 +194,8 @@ static void _check_group_change_message(
        }
 
        value = json_string_value(v);
-       if (strncmp(action, value, strlen(action) != 0)) {
+       cmp = strcmp(action, value);
+       if (cmp != 0) {
                print_error(
                    "Unexpected action \"%s\" != \"%s\"\n",
                    value,