Fix off-by-one error in working out the limit of the NetServerEnum comment.
authorJeremy Allison <jra@samba.org>
Tue, 9 Feb 2010 20:17:08 +0000 (12:17 -0800)
committerKarolin Seeger <kseeger@samba.org>
Mon, 15 Feb 2010 13:46:53 +0000 (14:46 +0100)
Jeremy.
(cherry picked from commit 9ad6f432f3f5844b4b419e7cbaf3c3e70b052d29)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 026f05839b6dbdeb5be3953930a28f7650c1e1da)

source3/libsmb/clirap.c

index 36b137e45d780c7f075c129d9d442e06b1122bfd..2abb550ab2997f1bb280c5b62e64ddcf9aded8cc 100644 (file)
@@ -366,7 +366,7 @@ bool cli_NetServerEnum(struct cli_state *cli, char *workgroup, uint32 stype,
                                comment_offset = (IVAL(p,22) & 0xFFFF)-converter;
                                cmnt = comment_offset?(rdata+comment_offset):"";
 
-                               if (comment_offset < 0 || comment_offset > (int)rdrcnt) {
+                               if (comment_offset < 0 || comment_offset >= (int)rdrcnt) {
                                        TALLOC_FREE(frame);
                                        continue;
                                }