ctdb-tools: Drop no-op stdout-filter from non-parallel case
authorMartin Schwenke <martin@meltin.net>
Fri, 28 Jun 2019 05:44:59 +0000 (15:44 +1000)
committerAmitay Isaacs <amitay@samba.org>
Fri, 5 Jul 2019 05:03:22 +0000 (05:03 +0000)
This filter no longer does anything useful in this context.  By
default it adds a pipeline with trailing cat process.  In many
contexts, stdout of the process being run is still open so the cat
process will stay around and will stop onnode from exiting.

The filters should all go away because they are simply an example of
code that is trying to be too clever while causing unfortunate corner
cases.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb/tools/onnode

index 76cd2217a0d93dd5912acde8391f70f788f152ca..863b8b393c53e4f6035291130cc46b8b41e24edf 100755 (executable)
@@ -352,7 +352,7 @@ for n in $nodes ; do
                        echo >&2 ; echo ">> NODE: $n <<" >&2
                fi
                {
-                       $ssh_cmd "$n" "$command" | stdout_filter
+                       $ssh_cmd "$n" "$command"
                } || retcode=$?
        fi
 done