nbt_server: Remove a pointless assignment
authorVolker Lendecke <vl@samba.org>
Sat, 17 Feb 2018 15:49:00 +0000 (16:49 +0100)
committerAndreas Schneider <asn@cryptomilk.org>
Tue, 27 Feb 2018 08:14:17 +0000 (09:14 +0100)
I don't see how data.msg.dest_name.type is accessed further down

dgram_mailslot_netlogon_reply only accesses packet->src_addr, packet->src_port
and packet->data.msg.source_name, *not* data.msg.dest_name. Also, "packet" is
thrown away after this call.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source4/nbt_server/dgram/netlogon.c

index 879e21dc63832fd6daa16425c3a2a5eaecfb824c..0954716c663a5e4f6625f0cd5f377d3009c03c3b 100644 (file)
@@ -131,8 +131,6 @@ static void nbtd_netlogon_samlogon(struct nbtd_interface *iface,
 
        netlogon_response.response_type = NETLOGON_SAMLOGON;
 
-       packet->data.msg.dest_name.type = 0;
-
        dgram_mailslot_netlogon_reply(reply_iface->dgmsock, 
                                      packet, 
                                      lpcfg_netbios_name(iface->nbtsrv->task->lp_ctx),