ctdb-ib: Avoid fall through case statements
authorAmitay Isaacs <amitay@gmail.com>
Sat, 3 Mar 2018 15:09:33 +0000 (02:09 +1100)
committerMartin Schwenke <martins@samba.org>
Fri, 9 Mar 2018 06:08:23 +0000 (07:08 +0100)
This is clearly unintended.  Noticed with gcc 7.3.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
ctdb/ib/ibwrapper.c

index f7334b528e7af82097500c50096744c864575090..5ca3b946f00f371bd8a6a0cd4eadcfe09fa14d9b 100644 (file)
@@ -503,10 +503,13 @@ static void ibw_event_handler_cm(struct tevent_context *ev,
 
        case RDMA_CM_EVENT_ADDR_ERROR:
                sprintf(ibw_lasterr, "RDMA_CM_EVENT_ADDR_ERROR, error %d\n", event->status);
+               goto error;
        case RDMA_CM_EVENT_ROUTE_ERROR:
                sprintf(ibw_lasterr, "RDMA_CM_EVENT_ROUTE_ERROR, error %d\n", event->status);
+               goto error;
        case RDMA_CM_EVENT_CONNECT_ERROR:
                sprintf(ibw_lasterr, "RDMA_CM_EVENT_CONNECT_ERROR, error %d\n", event->status);
+               goto error;
        case RDMA_CM_EVENT_UNREACHABLE:
                sprintf(ibw_lasterr, "RDMA_CM_EVENT_UNREACHABLE, error %d\n", event->status);
                goto error;