vfs_recycle: prevent flooding the log if we're called on non-existant paths
authorRalph Boehme <slow@samba.org>
Fri, 6 Mar 2020 11:22:25 +0000 (12:22 +0100)
committerIsaac Boukris <iboukris@sn-devel-184>
Mon, 9 Mar 2020 14:15:06 +0000 (14:15 +0000)
vfs_recycle is assuming that any path passed to unlink must exist, otherwise it
logs this error. Turn this into a DEBUG level message.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14316
See also: https://bugzilla.redhat.com/show_bug.cgi?id=1780802

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
Autobuild-User(master): Isaac Boukris <iboukris@samba.org>
Autobuild-Date(master): Mon Mar  9 14:15:06 UTC 2020 on sn-devel-184

source3/modules/vfs_recycle.c

index a1d32bf10cbdc7973f11c0d7d141a8d3ef81d2fc..ab1e6aa4dcffb00e1b9533a02a8e03788b24742c 100644 (file)
@@ -236,8 +236,8 @@ static off_t recycle_get_file_size(vfs_handle_struct *handle,
        }
 
        if (SMB_VFS_STAT(handle->conn, smb_fname_tmp) != 0) {
-               DEBUG(0,("recycle: stat for %s returned %s\n",
-                        smb_fname_str_dbg(smb_fname_tmp), strerror(errno)));
+               DBG_DEBUG("stat for %s returned %s\n",
+                        smb_fname_str_dbg(smb_fname_tmp), strerror(errno));
                size = (off_t)0;
                goto out;
        }