Volker Lendecke [Fri, 25 Jul 2008 10:08:03 +0000 (12:08 +0200)]
Fix a race condition in winbind leading to a crash
When SIGCHLD handling is delayed for some reason, sending a request to a child
can fail early because the child has died already. In this case
async_main_request_sent() directly called the continuation function without
properly removing the malfunctioning child process and the requests in the
queue. The next request would then crash in the DLIST_ADD_END() in
async_request() because the request pending for the child had been
talloc_free()'ed and yet still was referenced in the list.
This one is *old*...
Volker
(cherry picked from commit
8691709626b0d461de91b8fc9d10c730d1f183dd)
Karolin Seeger [Wed, 23 Jul 2008 15:07:56 +0000 (17:07 +0200)]
talloc_string_sub2: Don't return NULL if src is empty.
This fixes BUG #5635.
Finished print jobs were not removed from the $PRINTER.tdb file if
"printing=cups".
In print_queue_update, talloc_string_sub2 is used to assemble the
"lprm command". In the case of using "printing=cups", the default
"lprm command" is an empty string. talloc_string_sub2 is called with
this empty string and returns NULL which leads to exiting
print_queue_update without doing the actual print queue update.
Signed-off by Michael Adam <obnox@samba.org>
Jeremy Allison [Fri, 25 Jul 2008 01:12:12 +0000 (18:12 -0700)]
If we're not allowing streams on this conn ptr,
then don't allow create_file() to call down to
create_file_unixpath() with a stream name.
Jeremy.
Andreas Schneider [Mon, 21 Jul 2008 09:52:10 +0000 (11:52 +0200)]
Remove trailing withespace from wbinfo -m which breaks gdm auth.
Signed-off-by: Andreas Schneider <anschneider@suse.de>
Jeremy Allison [Thu, 24 Jul 2008 19:01:46 +0000 (12:01 -0700)]
Add casts to uint32_t to match prototype for sid_append_rid().
Jeremy.
Jeremy Allison [Thu, 24 Jul 2008 18:56:49 +0000 (11:56 -0700)]
Use sys_getgrnam not getgrnam. Pointed out by Herb.
Jeremy.
Steve French [Thu, 24 Jul 2008 14:35:20 +0000 (09:35 -0500)]
Merge branch 'v3-3-test' of git+ssh://sfrench@git.samba.org/data/git/samba into v33
Steve French [Thu, 24 Jul 2008 14:32:53 +0000 (09:32 -0500)]
cifs.upcall was not recognizing the newer name "dns_resolver" key type
(as a synonym for the older "cifs.resolver" name) when resolving host
names to ip addresses for the kernel.
Acked-by: Jeff Layton
Volker Lendecke [Thu, 24 Jul 2008 12:58:21 +0000 (14:58 +0200)]
Remove unused request_finished_cont()
Volker Lendecke [Thu, 24 Jul 2008 12:46:43 +0000 (14:46 +0200)]
Make use of TALLOC_FREE when freeing the per-winbindrequest memory context
John H Terpstra [Thu, 24 Jul 2008 07:45:02 +0000 (09:45 +0200)]
pdb_ldap: Raise level for debug message to avoid log file flooding.
Michael Adam [Wed, 23 Jul 2008 21:10:34 +0000 (23:10 +0200)]
re-run "make idl" after adding idl for idl for Primary:Kerberos-Newer-Keys
Michael
Stefan Metzmacher [Tue, 22 Jul 2008 10:28:07 +0000 (12:28 +0200)]
drsblobs.idl: add idl for Primary:Kerberos-Newer-Keys blob in supplementalCredentials
metze
(cherry picked from commit
97b7901afbccc9647ad2958d4cf12300de2655d1)
Michael Adam [Wed, 23 Jul 2008 21:06:30 +0000 (23:06 +0200)]
re-run "make idl" after fixing unknowns in package_PrimaryKerberos (drsblobs.idl)
Michael
Stefan Metzmacher [Wed, 23 Jul 2008 06:53:34 +0000 (08:53 +0200)]
drsblobs.idl: fix unknowns in package_PrimaryKerberos idl
metze
(cherry picked from commit
da9ceb2bf17f964334d9317829d40483e2c04b10)
Michael Adam [Wed, 23 Jul 2008 21:02:09 +0000 (23:02 +0200)]
re-run "make idl" after fixing idl for supplementalCredentialsSubBlob.
Michael
Stefan Metzmacher [Wed, 23 Jul 2008 11:06:32 +0000 (13:06 +0200)]
drsblobs.idl: fix idl for supplementalCredentialsSubBlob
metze
(cherry picked from commit
24c5b10136f6e640832193aaf9e6d7e865c288bc)
Michael Adam [Wed, 23 Jul 2008 20:42:18 +0000 (22:42 +0200)]
re-run "make idl" after changing unknown1->reserved in drsblobs.idl
Michael
Stefan Metzmacher [Wed, 23 Jul 2008 11:53:03 +0000 (13:53 +0200)]
drsblobs.idl: rename unknown1 -> reserved
metze
Steve French [Wed, 23 Jul 2008 19:25:17 +0000 (14:25 -0500)]
cifs.upcall: fix compile warning
Steve French noticed these warnings when building cifs.upcall:
Compiling client/cifs.upcall.c
client/cifs.upcall.c: In function 'usage':
client/cifs.upcall.c:204: warning: declaration of 'prog' shadows a global declaration
client/cifs.upcall.c:33: warning: shadowed declaration is here
Change the usage function to not take and arg and have it just use the global
"prog" variable. Fix a typo in the log message generated when an unknown
option is specified. Also getopt() always returns '?' when it sees an unknown
option so there's no point in printing it out.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Karolin Seeger [Tue, 22 Jul 2008 19:43:43 +0000 (21:43 +0200)]
rpc_parse: Unify spoolss debug messages.
Karolin
Michael Adam [Tue, 22 Jul 2008 14:18:03 +0000 (16:18 +0200)]
Change occurrences of the u1 member of DsBindInfo* to pid after idl change.
Michael
Michael Adam [Tue, 22 Jul 2008 14:15:15 +0000 (16:15 +0200)]
re-run "make idl" after changing u1 member to pid in DsBindInfo*.
Michael
Michael Adam [Tue, 22 Jul 2008 13:33:26 +0000 (15:33 +0200)]
drsuapi.idl: change the u1 field in DsBindInfo* to "pid".
According to the WSPP docs, section 5.35,
this is the "process identifyer" of the client.
It is meant for informational and debugging purposes
only and its assignment is implementation specific.
Michael
Zach Loafman [Thu, 3 Jul 2008 18:52:53 +0000 (11:52 -0700)]
Check for f_frsize when using statvfs
Add a configure test for the availability of f_frsize in struct statvfs
(for broken platforms that define statvfs but still have
f_bsize/f_iosize). Also add sys/types.h to the other struct statvfs test
(again, some platforms need it).
Zach Loafman [Wed, 9 Jul 2008 07:05:50 +0000 (00:05 -0700)]
Make DSO_EXPORTS_CMD regexp more POSIX compliant
The FreeBSD sed command doesn't understand \? without passing -E to turn
on extended regexps. This patch changes the DSO_EXPORTS_CMD regexp to a
POSIX compliant RE by switching the \+ to a \{1,\} bound and the \? to a
\{0,1\} bound.
Zach Loafman [Thu, 3 Jul 2008 19:21:33 +0000 (12:21 -0700)]
Fix warnings on FreeBSD-based platforms
Fix two shadowed declaration warnings on FreeBSD-based platform:
'reboot' is a 4.0BSD syscall in unistd.h and 'tcp_seq' is a typedef in
netinet/tcp.h.
Zach Loafman [Fri, 4 Jul 2008 05:53:42 +0000 (22:53 -0700)]
Fix various build warnings
This fixes various build warnings on our platform. I'm sure I haven't
caught them all, but it's a start.
Zach Loafman [Thu, 3 Jul 2008 20:45:07 +0000 (13:45 -0700)]
Add --enable-picky-developer
This adds an --enable-picky-developer option that will halt compilation
on warnings. Yes, this could be handled by a direct Makefile change, but
people should be encourage to do it!
Michael Adam [Tue, 22 Jul 2008 10:16:46 +0000 (12:16 +0200)]
rpcclient: make DsGetNCChanges work against w2k8 (add knowledge of DsBindInfo48)
Michael
Michael Adam [Tue, 22 Jul 2008 11:23:18 +0000 (13:23 +0200)]
re-run make idl after adding drsuapi_DsBindInfo48 to drsuapi.idl
Michael
Michael Adam [Tue, 22 Jul 2008 11:07:55 +0000 (13:07 +0200)]
drsuapi.idl: add drsuapi_SupportedExtensionsExt bitfield.
This knowledge is obtained from the wspp-docs (section 5.35).
Michael
(cherry picked from commit
f5afb695045b1a2f3b8c00a4d82d40e8e50726c9)
Michael Adam [Tue, 22 Jul 2008 10:46:04 +0000 (12:46 +0200)]
drsuapi.idl: the last 16 bytes in DsBindInfo48 ar the GUID of the config dn.
This bit seems not to be documented in the WSPP docs.
Michael
(cherry picked from commit
705f79bd0a5e93daa0cb11b5dcca36e75c75df93)
Michael Adam [Tue, 22 Jul 2008 09:37:32 +0000 (11:37 +0200)]
drsuapi.idl: add drsuapi_DsBindInfo48.
This is necessary to make DsGetNcChanges work with win2008.
Michael
(cherry picked from commit
dd278b069b8683a0e3721ebb7d0de06d2bc1c86f)
Michael Adam [Tue, 22 Jul 2008 09:54:54 +0000 (11:54 +0200)]
re-run make idl after Jelmer's "poperly cast array lengths" pidl change.
(
f321240fa91fa19c1131f119c42f64897d220682)
Michael
Karolin Seeger [Tue, 22 Jul 2008 09:27:16 +0000 (11:27 +0200)]
man pages: "printcap name" is a global parameter, not a share specific one.
Karolin
Volker Lendecke [Mon, 21 Jul 2008 14:12:22 +0000 (16:12 +0200)]
Update Roadmap
(cherry picked from commit
d1c3b57085b493b47398daf71ce18f16ece57da0)
Volker Lendecke [Mon, 21 Jul 2008 11:30:45 +0000 (13:30 +0200)]
YESS -- remove the PI_* pipe constants
Volker Lendecke [Mon, 21 Jul 2008 11:04:41 +0000 (13:04 +0200)]
Make idl: cli_do_rpc_ndr does not use pipe_idx anymore
Volker Lendecke [Mon, 21 Jul 2008 11:04:13 +0000 (13:04 +0200)]
Remove unused function rpccli_is_pipe_idx
Volker Lendecke [Mon, 21 Jul 2008 10:50:32 +0000 (12:50 +0200)]
Refactoring: CLI_DO_RPC_* uses interface instead of pipe_idx
Volker Lendecke [Mon, 21 Jul 2008 10:49:50 +0000 (12:49 +0200)]
Remove a reference to pipe_idx
Volker Lendecke [Mon, 21 Jul 2008 10:05:46 +0000 (12:05 +0200)]
Remove some unused code
Volker Lendecke [Mon, 21 Jul 2008 10:04:44 +0000 (12:04 +0200)]
Remove one reference to PI_NETLOGON
Volker Lendecke [Mon, 21 Jul 2008 10:01:12 +0000 (12:01 +0200)]
Remove one reference to PI_LSARPC
Volker Lendecke [Mon, 21 Jul 2008 09:57:11 +0000 (11:57 +0200)]
Remove some fully outdated sample code
Volker Lendecke [Sun, 20 Jul 2008 16:48:44 +0000 (18:48 +0200)]
Remove now unused cli_get_pipe_name
Volker Lendecke [Sun, 20 Jul 2008 16:46:13 +0000 (18:46 +0200)]
Remove now unused cli_get_pipe_idx
Volker Lendecke [Sun, 20 Jul 2008 16:45:39 +0000 (18:45 +0200)]
Remove now unused cli_get_iface
Volker Lendecke [Sun, 20 Jul 2008 16:44:32 +0000 (18:44 +0200)]
Refactoring: connect_dst_pipe uses ndr_syntax_id instead of pipe_idx
Volker Lendecke [Sun, 20 Jul 2008 16:40:31 +0000 (18:40 +0200)]
Refactoring: net_sh_run uses ndr_syntax_id instead of pipe_idx
Volker Lendecke [Sun, 20 Jul 2008 16:36:31 +0000 (18:36 +0200)]
Refactoring: run_rpc_command uses ndr_syntax_id instead of pipe_idx
Volker Lendecke [Sun, 20 Jul 2008 16:17:52 +0000 (18:17 +0200)]
Refactoring: rpcclient uses ndr_syntax_id instead of pipe_idx
Volker Lendecke [Sun, 20 Jul 2008 15:59:30 +0000 (17:59 +0200)]
Refactoring: libnetapi_open_pipe takes an interface instead of pipe_idx
Michael Adam [Mon, 21 Jul 2008 09:23:55 +0000 (11:23 +0200)]
testsuite: fix expr error on Tru64, triggered by uninitialized failed variable.
Michael
Michael Adam [Mon, 21 Jul 2008 09:17:36 +0000 (11:17 +0200)]
testsuite: fix another expr syntax error. in tests_all.sh.
Michael
Michael Adam [Sun, 20 Jul 2008 21:49:40 +0000 (23:49 +0200)]
testsuite: fix expr syntax error in net registry test.
Pointed out by Björn Jacke <bj@sernet.de>.
Michael
Volker Lendecke [Sun, 20 Jul 2008 09:04:31 +0000 (11:04 +0200)]
Refactoring: Change calling conventions for cli_rpc_pipe_open_krb5
Pass in ndr_syntax_id instead of pipe_idx, return NTSTATUS
Volker Lendecke [Sun, 20 Jul 2008 09:04:31 +0000 (11:04 +0200)]
Refactoring: Change calling conventions for cli_rpc_pipe_open_schannel
Pass in ndr_syntax_id instead of pipe_idx, return NTSTATUS
Volker Lendecke [Sun, 20 Jul 2008 09:04:31 +0000 (11:04 +0200)]
Refactoring: Change calling conventions for cli_rpc_pipe_open_ntlmssp_auth_schannel
Pass in ndr_syntax_id instead of pipe_idx, return NTSTATUS
Volker Lendecke [Sun, 20 Jul 2008 09:04:31 +0000 (11:04 +0200)]
Refactoring: Change calling conventions for cli_rpc_pipe_open_schannel_with_key
Pass in ndr_syntax_id instead of pipe_idx, return NTSTATUS
Volker Lendecke [Sun, 20 Jul 2008 14:36:55 +0000 (16:36 +0200)]
Refactoring: Make get_schannel_session_key_auth_ntlmssp return NTSTATUS
Volker Lendecke [Sun, 20 Jul 2008 14:33:26 +0000 (16:33 +0200)]
Refactoring: Make get_schannel_session_key return NTSTATUS
Volker Lendecke [Sun, 20 Jul 2008 14:27:45 +0000 (16:27 +0200)]
Refactoring: Make get_schannel_session_key_common return NTSTATUS
Volker Lendecke [Sun, 20 Jul 2008 09:04:31 +0000 (11:04 +0200)]
Refactoring: Change calling conventions for cli_rpc_pipe_open_ntlmssp
Pass in ndr_syntax_id instead of pipe_idx, return NTSTATUS
Volker Lendecke [Sun, 20 Jul 2008 09:04:31 +0000 (11:04 +0200)]
Refactoring: Change calling conventions for cli_rpc_pipe_open_noauth
Pass in ndr_syntax_id instead of pipe_idx, return NTSTATUS
Volker Lendecke [Sun, 20 Jul 2008 09:04:31 +0000 (11:04 +0200)]
Refactoring: Change calling conventions for cli_rpc_pipe_open
Pass in ndr_syntax_id instead of pipe_idx, return NTSTATUS
Volker Lendecke [Sun, 20 Jul 2008 08:56:36 +0000 (10:56 +0200)]
Refactoring: Change calling conventions for rpc_pipe_open_np
Pass in ndr_syntax_id instead of pipe_idx, return NTSTATUS
Volker Lendecke [Sun, 20 Jul 2008 08:40:43 +0000 (10:40 +0200)]
Allocate rpc_cli->dc in rpccli_netlogon_setup_creds()
The general cli_pipe routines should not have to know about this NETLOGON
speciality.
Volker Lendecke [Sun, 20 Jul 2008 08:21:14 +0000 (10:21 +0200)]
Store copies of the syntax ids in rpc_pipe_client
Volker Lendecke [Sun, 20 Jul 2008 08:00:46 +0000 (10:00 +0200)]
Simplify pipe_names: we only do ndr_transfer_syntax anyway
Alexander Bokovoy [Sat, 19 Jul 2008 20:11:50 +0000 (00:11 +0400)]
Fix link for Using Samba
Volker Lendecke [Sat, 19 Jul 2008 19:07:14 +0000 (21:07 +0200)]
The PIPE_ pipename macros are only used in cli_pipe.c
Volker Lendecke [Sat, 19 Jul 2008 18:40:27 +0000 (20:40 +0200)]
Make the pipe_names[] array static to cli_pipe.c
Volker Lendecke [Sat, 19 Jul 2008 18:27:56 +0000 (20:27 +0200)]
Introduce is_known_pipename
This scans the list of pipes registered via rpc_pipe_register_commands instead
of using static tables.
Volker Lendecke [Sat, 19 Jul 2008 17:53:01 +0000 (19:53 +0200)]
Make use of ndr_syntax_id_equal
Volker Lendecke [Sat, 19 Jul 2008 17:50:36 +0000 (19:50 +0200)]
Ooops, GUID_equal was already around :-)
Volker Lendecke [Fri, 18 Jul 2008 08:01:39 +0000 (10:01 +0200)]
Fix the build of vfs_zfsacl.c
(cherry picked from commit
b83beeda44e1c8d485c2ad6bb8ee539cdcbe8bda)
Günther Deschner [Thu, 17 Jul 2008 20:44:24 +0000 (22:44 +0200)]
netapi: add caching of samr policy handles.
Guenther
Günther Deschner [Fri, 18 Jul 2008 14:24:02 +0000 (16:24 +0200)]
netapi: let libnetapi_samr_lookup_and_open_alias compose lsa string.
Guenther
Günther Deschner [Fri, 18 Jul 2008 13:11:08 +0000 (15:11 +0200)]
netapi: implement NetLocalGroupEnum_r.
Guenther
Günther Deschner [Thu, 17 Jul 2008 23:41:30 +0000 (01:41 +0200)]
netapi: add NetLocalGroupEnum example code.
Guenther
Günther Deschner [Thu, 17 Jul 2008 23:40:34 +0000 (01:40 +0200)]
netapi: add NetLocalGroupEnum to public header.
Guenther
Günther Deschner [Thu, 17 Jul 2008 23:23:26 +0000 (01:23 +0200)]
netapi: add skeleton for NetLocalGroupEnum().
Guenther
Günther Deschner [Thu, 17 Jul 2008 23:21:38 +0000 (01:21 +0200)]
re-run make idl.
Guenther
Günther Deschner [Thu, 17 Jul 2008 23:20:56 +0000 (01:20 +0200)]
netapi: add NetLocalGroupEnum to IDL.
Guenther
Günther Deschner [Fri, 18 Jul 2008 13:10:43 +0000 (15:10 +0200)]
netapi: make map_alias_info_to_buffer suitable for arrays in the buffer.
Guenther
Günther Deschner [Fri, 18 Jul 2008 13:01:21 +0000 (15:01 +0200)]
netapi: add libnetapi_samr_open_alias_queryinfo.
Guenther
Günther Deschner [Fri, 18 Jul 2008 00:23:29 +0000 (02:23 +0200)]
netapi: add NetUserSetInfo example code.
Guenther
Günther Deschner [Thu, 17 Jul 2008 23:40:14 +0000 (01:40 +0200)]
netapi: add NetUserSetInfo to public header.
Guenther
Günther Deschner [Wed, 16 Jul 2008 23:00:33 +0000 (01:00 +0200)]
netapi: add skeleton for NetUserSetInfo.
Guenther
Günther Deschner [Wed, 16 Jul 2008 22:59:57 +0000 (00:59 +0200)]
re-run make idl.
Guenther
Günther Deschner [Wed, 16 Jul 2008 22:59:13 +0000 (00:59 +0200)]
netapi: add NetUserSetInfo to IDL.
Guenther
Günther Deschner [Thu, 17 Jul 2008 20:45:09 +0000 (22:45 +0200)]
netapi: fill in NetUserGetInfo_r().
Guenther
Günther Deschner [Wed, 16 Jul 2008 08:59:53 +0000 (10:59 +0200)]
netapi: add NetUserGetInfo example code.
Guenther
Günther Deschner [Wed, 16 Jul 2008 08:50:26 +0000 (10:50 +0200)]
netapi: add NetUserGetInfo to public headers.
Guenther
Günther Deschner [Wed, 16 Jul 2008 08:47:38 +0000 (10:47 +0200)]
netapi: add skeleton for NetUserGetInfo().
Guenther
Günther Deschner [Wed, 16 Jul 2008 08:45:31 +0000 (10:45 +0200)]
re-run make idl.
Guenther
Günther Deschner [Wed, 16 Jul 2008 08:45:11 +0000 (10:45 +0200)]
netapi: add NetUserGetInfo to IDL.
Guenther
Günther Deschner [Tue, 1 Jul 2008 18:19:10 +0000 (20:19 +0200)]
netapi: support more infolevels in NetUserEnum.
Guenther