io_uring: remove 'loops' argument from trace_io_uring_task_work_run()
authorJens Axboe <axboe@kernel.dk>
Tue, 30 Jan 2024 14:03:46 +0000 (07:03 -0700)
committerJens Axboe <axboe@kernel.dk>
Thu, 8 Feb 2024 20:27:06 +0000 (13:27 -0700)
We no longer loop in task_work handling, hence delete the argument from
the tracepoint as it's always 1 and hence not very informative.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
include/trace/events/io_uring.h
io_uring/io_uring.c

index b241f2b124863a6aa5ccf0ad82873aea993acbea..e948df7ce62597507d88327723d5586f578c5c8d 100644 (file)
@@ -602,29 +602,25 @@ TRACE_EVENT(io_uring_cqe_overflow,
  *
  * @tctx:              pointer to a io_uring_task
  * @count:             how many functions it ran
- * @loops:             how many loops it ran
  *
  */
 TRACE_EVENT(io_uring_task_work_run,
 
-       TP_PROTO(void *tctx, unsigned int count, unsigned int loops),
+       TP_PROTO(void *tctx, unsigned int count),
 
-       TP_ARGS(tctx, count, loops),
+       TP_ARGS(tctx, count),
 
        TP_STRUCT__entry (
                __field(  void *,               tctx            )
                __field(  unsigned int,         count           )
-               __field(  unsigned int,         loops           )
        ),
 
        TP_fast_assign(
                __entry->tctx           = tctx;
                __entry->count          = count;
-               __entry->loops          = loops;
        ),
 
-       TP_printk("tctx %p, count %u, loops %u",
-                __entry->tctx, __entry->count, __entry->loops)
+       TP_printk("tctx %p, count %u", __entry->tctx, __entry->count)
 );
 
 TRACE_EVENT(io_uring_short_write,
index f4df5bbe17c74f4c0f0f60d2c3fd6444c0965aa1..b1892cdd25c637eafa3e09255d77a3435293e363 100644 (file)
@@ -1274,7 +1274,7 @@ void tctx_task_work(struct callback_head *cb)
        if (unlikely(atomic_read(&tctx->in_cancel)))
                io_uring_drop_tctx_refs(current);
 
-       trace_io_uring_task_work_run(tctx, count, 1);
+       trace_io_uring_task_work_run(tctx, count);
 }
 
 static inline void io_req_local_work_add(struct io_kiocb *req, unsigned flags)