ata: libata-core: Detach a port devices on shutdown

Modify ata_pci_shutdown_one() to schedule EH to unload a port devices
before freezing and thawing the port. This ensures that drives are
cleanly disabled and transitioned to standby power mode when
a PCI adapter is removed or the system is powered off.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 2b7b88e74c2b47c3d729810cd61457c551c2199f..a4d5d2fcf3b983651e18edd6080b214bc0058b0b 100644 (file)
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -6164,10 +6164,24 @@ EXPORT_SYMBOL_GPL(ata_pci_remove_one);
 void ata_pci_shutdown_one(struct pci_dev *pdev)
 {
        struct ata_host *host = pci_get_drvdata(pdev);
+       struct ata_port *ap;
+       unsigned long flags;
        int i;
 
+       /* Tell EH to disable all devices */
        for (i = 0; i < host->n_ports; i++) {
-               struct ata_port *ap = host->ports[i];
+               ap = host->ports[i];
+               spin_lock_irqsave(ap->lock, flags);
+               ap->pflags |= ATA_PFLAG_UNLOADING;
+               ata_port_schedule_eh(ap);
+               spin_unlock_irqrestore(ap->lock, flags);
+       }
+
+       for (i = 0; i < host->n_ports; i++) {
+               ap = host->ports[i];
+
+               /* Wait for EH to complete before freezing the port */
+               ata_port_wait_eh(ap);
 
                ap->pflags |= ATA_PFLAG_FROZEN;