scsi: isci: Convert snprintf() to sysfs_emit()
authorLi Zhijian <lizhijian@fujitsu.com>
Tue, 16 Jan 2024 04:51:36 +0000 (12:51 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 30 Jan 2024 01:40:49 +0000 (20:40 -0500)
Per filesystems/sysfs.rst, show() should only use sysfs_emit() or
sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

> ./drivers/scsi/isci/init.c:140:8-16: WARNING: please use sysfs_emit

No functional change intended

CC: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
CC: James E.J. Bottomley <jejb@linux.ibm.com>
CC: Martin K. Petersen <martin.petersen@oracle.com>
CC: linux-scsi@vger.kernel.org
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Link: https://lore.kernel.org/r/20240116045151.3940401-25-lizhijian@fujitsu.com
Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/isci/init.c

index 6277162a028bb98378d66c34e7a9f47a20323027..c582a3932ceab74a6cda37cc6c243b4d943f529b 100644 (file)
@@ -137,7 +137,7 @@ static ssize_t isci_show_id(struct device *dev, struct device_attribute *attr, c
        struct sas_ha_struct *sas_ha = SHOST_TO_SAS_HA(shost);
        struct isci_host *ihost = container_of(sas_ha, typeof(*ihost), sas_ha);
 
-       return snprintf(buf, PAGE_SIZE, "%d\n", ihost->id);
+       return sysfs_emit(buf, "%d\n", ihost->id);
 }
 
 static DEVICE_ATTR(isci_id, S_IRUGO, isci_show_id, NULL);