cifs: Fix FALLOC_FL_INSERT_RANGE by setting i_size after EOF moved
authorSteve French <stfrench@microsoft.com>
Fri, 26 Jan 2024 23:59:34 +0000 (17:59 -0600)
committerSteve French <stfrench@microsoft.com>
Sat, 27 Jan 2024 06:28:47 +0000 (00:28 -0600)
Fix the cifs filesystem implementations of FALLOC_FL_INSERT_RANGE, in
smb3_insert_range(), to set i_size after extending the file on the server
and before we do the copy to open the gap (as we don't clean up the EOF
marker if the copy fails).

Fixes: 7fe6fe95b936 ("cifs: add FALLOC_FL_INSERT_RANGE support")
Cc: stable@vger.kernel.org
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Paulo Alcantara <pc@manguebit.com>
cc: Shyam Prasad N <nspmangalore@gmail.com>
cc: Rohith Surabattula <rohiths.msft@gmail.com>
cc: Jeff Layton <jlayton@kernel.org>
cc: linux-cifs@vger.kernel.org
cc: linux-mm@kvack.org
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/smb2ops.c

index d5bc54074eab6b89e35c9ad53acfb1385ed89902..57355e7135d02ef1554e7c92455d58c27f640184 100644 (file)
@@ -3742,6 +3742,9 @@ static long smb3_insert_range(struct file *file, struct cifs_tcon *tcon,
        if (rc < 0)
                goto out_2;
 
+       truncate_setsize(inode, old_eof + len);
+       /* fscache_resize_cookie(cifs_inode_cookie(inode), i_size_read(inode)); */ /* VFS helper function not backported */
+
        rc = smb2_copychunk_range(xid, cfile, cfile, off, count, off + len);
        if (rc < 0)
                goto out_2;