arm64/efi: Do not enter virtual mode if booting with efi=noruntime or noefi
authorDave Young <dyoung@redhat.com>
Mon, 18 Aug 2014 01:30:07 +0000 (09:30 +0800)
committerMatt Fleming <matt.fleming@intel.com>
Fri, 3 Oct 2014 17:40:59 +0000 (18:40 +0100)
In case efi runtime disabled via noefi kernel cmdline
arm64_enter_virtual_mode should error out.

At the same time move early_memunmap(memmap.map, mapsize) to the
beginning of the function or it will leak early mem.

Signed-off-by: Dave Young <dyoung@redhat.com>
Reviewed-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
arch/arm64/kernel/efi.c

index 6ed0362dd579bbd44f4693576ae8a2f620a5f142..8f5db4a3c9d9c51f284c276d2d98bea9883d3529 100644 (file)
@@ -392,11 +392,16 @@ static int __init arm64_enter_virtual_mode(void)
                return -1;
        }
 
-       pr_info("Remapping and enabling EFI services.\n");
-
-       /* replace early memmap mapping with permanent mapping */
        mapsize = memmap.map_end - memmap.map;
        early_memunmap(memmap.map, mapsize);
+
+       if (efi_runtime_disabled()) {
+               pr_info("EFI runtime services will be disabled.\n");
+               return -1;
+       }
+
+       pr_info("Remapping and enabling EFI services.\n");
+       /* replace early memmap mapping with permanent mapping */
        memmap.map = (__force void *)ioremap_cache((phys_addr_t)memmap.phys_map,
                                                   mapsize);
        memmap.map_end = memmap.map + mapsize;