crypto: ccp - Provide MMIO register naming for documenation
authorTom Lendacky <thomas.lendacky@amd.com>
Mon, 16 Jan 2023 20:03:26 +0000 (14:03 -0600)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 27 Jan 2023 10:57:24 +0000 (18:57 +0800)
Add comments next to the version data MMIO register values to identify
the register name being used.

Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/ccp/sp-pci.c

index 084d052fddccbd63514efc15d7a3b95ceffba139..cde33b2ac71b25f8b21932e82e4b923266bf9d1f 100644 (file)
@@ -342,52 +342,52 @@ static int __maybe_unused sp_pci_resume(struct device *dev)
 
 #ifdef CONFIG_CRYPTO_DEV_SP_PSP
 static const struct sev_vdata sevv1 = {
-       .cmdresp_reg            = 0x10580,
-       .cmdbuff_addr_lo_reg    = 0x105e0,
-       .cmdbuff_addr_hi_reg    = 0x105e4,
+       .cmdresp_reg            = 0x10580,      /* C2PMSG_32 */
+       .cmdbuff_addr_lo_reg    = 0x105e0,      /* C2PMSG_56 */
+       .cmdbuff_addr_hi_reg    = 0x105e4,      /* C2PMSG_57 */
 };
 
 static const struct sev_vdata sevv2 = {
-       .cmdresp_reg            = 0x10980,
-       .cmdbuff_addr_lo_reg    = 0x109e0,
-       .cmdbuff_addr_hi_reg    = 0x109e4,
+       .cmdresp_reg            = 0x10980,      /* C2PMSG_32 */
+       .cmdbuff_addr_lo_reg    = 0x109e0,      /* C2PMSG_56 */
+       .cmdbuff_addr_hi_reg    = 0x109e4,      /* C2PMSG_57 */
 };
 
 static const struct tee_vdata teev1 = {
-       .cmdresp_reg            = 0x10544,
-       .cmdbuff_addr_lo_reg    = 0x10548,
-       .cmdbuff_addr_hi_reg    = 0x1054c,
-       .ring_wptr_reg          = 0x10550,
-       .ring_rptr_reg          = 0x10554,
+       .cmdresp_reg            = 0x10544,      /* C2PMSG_17 */
+       .cmdbuff_addr_lo_reg    = 0x10548,      /* C2PMSG_18 */
+       .cmdbuff_addr_hi_reg    = 0x1054c,      /* C2PMSG_19 */
+       .ring_wptr_reg          = 0x10550,      /* C2PMSG_20 */
+       .ring_rptr_reg          = 0x10554,      /* C2PMSG_21 */
 };
 
 static const struct psp_vdata pspv1 = {
        .sev                    = &sevv1,
-       .feature_reg            = 0x105fc,
-       .inten_reg              = 0x10610,
-       .intsts_reg             = 0x10614,
+       .feature_reg            = 0x105fc,      /* C2PMSG_63 */
+       .inten_reg              = 0x10610,      /* P2CMSG_INTEN */
+       .intsts_reg             = 0x10614,      /* P2CMSG_INTSTS */
 };
 
 static const struct psp_vdata pspv2 = {
        .sev                    = &sevv2,
-       .feature_reg            = 0x109fc,
-       .inten_reg              = 0x10690,
-       .intsts_reg             = 0x10694,
+       .feature_reg            = 0x109fc,      /* C2PMSG_63 */
+       .inten_reg              = 0x10690,      /* P2CMSG_INTEN */
+       .intsts_reg             = 0x10694,      /* P2CMSG_INTSTS */
 };
 
 static const struct psp_vdata pspv3 = {
        .tee                    = &teev1,
-       .feature_reg            = 0x109fc,
-       .inten_reg              = 0x10690,
-       .intsts_reg             = 0x10694,
+       .feature_reg            = 0x109fc,      /* C2PMSG_63 */
+       .inten_reg              = 0x10690,      /* P2CMSG_INTEN */
+       .intsts_reg             = 0x10694,      /* P2CMSG_INTSTS */
 };
 
 static const struct psp_vdata pspv4 = {
        .sev                    = &sevv2,
        .tee                    = &teev1,
-       .feature_reg            = 0x109fc,
-       .inten_reg              = 0x10690,
-       .intsts_reg             = 0x10694,
+       .feature_reg            = 0x109fc,      /* C2PMSG_63 */
+       .inten_reg              = 0x10690,      /* P2CMSG_INTEN */
+       .intsts_reg             = 0x10694,      /* P2CMSG_INTSTS */
 };
 
 #endif