drivers/ptp: Convert snprintf to sysfs_emit
authorLi Zhijian <lizhijian@fujitsu.com>
Thu, 25 Jan 2024 01:53:29 +0000 (09:53 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 27 Jan 2024 04:35:17 +0000 (20:35 -0800)
Per filesystems/sysfs.rst, show() should only use sysfs_emit()
or sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

> ./drivers/ptp/ptp_sysfs.c:27:8-16: WARNING: please use sysfs_emit

No functional change intended

Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Link: https://lore.kernel.org/r/20240125015329.123023-1-lizhijian@fujitsu.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/ptp/ptp_sysfs.c

index f7a499a1bd39ec22edf6c77407a48736e137f277..a15460aaa03b3a069b6f2f68967b04f47cb52d77 100644 (file)
@@ -24,8 +24,7 @@ static ssize_t max_phase_adjustment_show(struct device *dev,
 {
        struct ptp_clock *ptp = dev_get_drvdata(dev);
 
-       return snprintf(page, PAGE_SIZE - 1, "%d\n",
-                       ptp->info->getmaxphase(ptp->info));
+       return sysfs_emit(page, "%d\n", ptp->info->getmaxphase(ptp->info));
 }
 static DEVICE_ATTR_RO(max_phase_adjustment);
 
@@ -34,7 +33,7 @@ static ssize_t var##_show(struct device *dev,                         \
                           struct device_attribute *attr, char *page)   \
 {                                                                      \
        struct ptp_clock *ptp = dev_get_drvdata(dev);                   \
-       return snprintf(page, PAGE_SIZE-1, "%d\n", ptp->info->var);     \
+       return sysfs_emit(page, "%d\n", ptp->info->var);        \
 }                                                                      \
 static DEVICE_ATTR(name, 0444, var##_show, NULL);
 
@@ -102,8 +101,8 @@ static ssize_t extts_fifo_show(struct device *dev,
        if (!qcnt)
                goto out;
 
-       cnt = snprintf(page, PAGE_SIZE, "%u %lld %u\n",
-                      event.index, event.t.sec, event.t.nsec);
+       cnt = sysfs_emit(page, "%u %lld %u\n",
+                        event.index, event.t.sec, event.t.nsec);
 out:
        return cnt;
 }
@@ -194,7 +193,7 @@ static ssize_t n_vclocks_show(struct device *dev,
        if (mutex_lock_interruptible(&ptp->n_vclocks_mux))
                return -ERESTARTSYS;
 
-       size = snprintf(page, PAGE_SIZE - 1, "%u\n", ptp->n_vclocks);
+       size = sysfs_emit(page, "%u\n", ptp->n_vclocks);
 
        mutex_unlock(&ptp->n_vclocks_mux);
 
@@ -270,7 +269,7 @@ static ssize_t max_vclocks_show(struct device *dev,
        struct ptp_clock *ptp = dev_get_drvdata(dev);
        ssize_t size;
 
-       size = snprintf(page, PAGE_SIZE - 1, "%u\n", ptp->max_vclocks);
+       size = sysfs_emit(page, "%u\n", ptp->max_vclocks);
 
        return size;
 }