net: dsa: mt7530: do not clear config->supported_interfaces
authorArınç ÜNAL <arinc.unal@arinc9.com>
Mon, 5 Feb 2024 22:08:08 +0000 (01:08 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 8 Feb 2024 02:53:53 +0000 (18:53 -0800)
There's no need to clear the config->supported_interfaces bitmap before
reporting the supported interfaces as all bits in the bitmap will already
be initialized to zero when the phylink_config structure is allocated. The
"config" pointer points to &dp->phylink_config, and "dp" is allocated by
dsa_port_touch() with kzalloc(), so all its fields are filled with zeroes.

There's no code that would change the bitmap beforehand. Remove it.

Acked-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Link: https://lore.kernel.org/r/20240206-for-netnext-mt7530-improvements-2-v5-7-d7d92a185cb1@arinc9.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/mt7530.c

index 6b29dec7c6bb4327d399dc32514baaf76c8f2fb5..03d966fa67b2cad6f064b46d4da567f0e9586b7b 100644 (file)
@@ -2573,8 +2573,6 @@ static void mt7531_mac_port_get_caps(struct dsa_switch *ds, int port,
 static void mt7988_mac_port_get_caps(struct dsa_switch *ds, int port,
                                     struct phylink_config *config)
 {
-       phy_interface_zero(config->supported_interfaces);
-
        switch (port) {
        /* Ports which are connected to switch PHYs. There is no MII pinout. */
        case 0 ... 3: