SMB3: clarify some of the unused CreateOption flags
authorSteve French <stfrench@microsoft.com>
Fri, 26 Jan 2024 00:57:03 +0000 (18:57 -0600)
committerSteve French <stfrench@microsoft.com>
Sat, 27 Jan 2024 06:14:27 +0000 (00:14 -0600)
Update comments to show flags which should be not set (zero).

See MS-SMB2 section 2.2.13

Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smbfs_common/smb2pdu.h

index 319fb9ffc6a03212011007da32761e9781369ce0..0c3955e6fdb9fbd96ea2545556f82396c5e9e4b5 100644 (file)
@@ -1097,16 +1097,23 @@ struct smb2_change_notify_rsp {
 #define FILE_WRITE_THROUGH_LE          cpu_to_le32(0x00000002)
 #define FILE_SEQUENTIAL_ONLY_LE                cpu_to_le32(0x00000004)
 #define FILE_NO_INTERMEDIATE_BUFFERING_LE cpu_to_le32(0x00000008)
+/* FILE_SYNCHRONOUS_IO_ALERT_LE                cpu_to_le32(0x00000010) should be zero, ignored */
+/* FILE_SYNCHRONOUS_IO_NONALERT                cpu_to_le32(0x00000020) should be zero, ignored */
 #define FILE_NON_DIRECTORY_FILE_LE     cpu_to_le32(0x00000040)
 #define FILE_COMPLETE_IF_OPLOCKED_LE   cpu_to_le32(0x00000100)
 #define FILE_NO_EA_KNOWLEDGE_LE                cpu_to_le32(0x00000200)
+/* FILE_OPEN_REMOTE_INSTANCE           cpu_to_le32(0x00000400) should be zero, ignored */
 #define FILE_RANDOM_ACCESS_LE          cpu_to_le32(0x00000800)
-#define FILE_DELETE_ON_CLOSE_LE                cpu_to_le32(0x00001000)
+#define FILE_DELETE_ON_CLOSE_LE                cpu_to_le32(0x00001000) /* MBZ */
 #define FILE_OPEN_BY_FILE_ID_LE                cpu_to_le32(0x00002000)
 #define FILE_OPEN_FOR_BACKUP_INTENT_LE cpu_to_le32(0x00004000)
 #define FILE_NO_COMPRESSION_LE         cpu_to_le32(0x00008000)
+/* FILE_OPEN_REQUIRING_OPLOCK          cpu_to_le32(0x00010000) should be zero, ignored */
+/* FILE_DISALLOW_EXCLUSIVE             cpu_to_le32(0x00020000) should be zero, ignored */
+/* FILE_RESERVE_OPFILTER               cpu_to_le32(0x00100000) MBZ */
 #define FILE_OPEN_REPARSE_POINT_LE     cpu_to_le32(0x00200000)
 #define FILE_OPEN_NO_RECALL_LE         cpu_to_le32(0x00400000)
+/* #define FILE_OPEN_FOR_FREE_SPACE_QUERY cpu_to_le32(0x00800000) should be zero, ignored */
 #define CREATE_OPTIONS_MASK_LE          cpu_to_le32(0x00FFFFFF)
 
 #define FILE_READ_RIGHTS_LE (FILE_READ_DATA_LE | FILE_READ_EA_LE \