pds_core: no health reporter in VF
authorShannon Nelson <shannon.nelson@amd.com>
Thu, 24 Aug 2023 16:17:51 +0000 (09:17 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 26 Aug 2023 02:05:58 +0000 (19:05 -0700)
Make sure the health reporter is set up before we use it in
our devlink health updates, especially since the VF doesn't
set up the health reporter.

Fixes: 25b450c05a49 ("pds_core: add devlink health facilities")
Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Reviewed-by: Brett Creeley <brett.creeley@amd.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20230824161754.34264-3-shannon.nelson@amd.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/amd/pds_core/core.c

index f2c79456d74525e3dc8ca47fa620161ba5a1ce1a..383e3311a52c2517bd5bd30926ce38d629af6105 100644 (file)
@@ -524,7 +524,8 @@ static void pdsc_fw_down(struct pdsc *pdsc)
        }
 
        /* Notify clients of fw_down */
-       devlink_health_report(pdsc->fw_reporter, "FW down reported", pdsc);
+       if (pdsc->fw_reporter)
+               devlink_health_report(pdsc->fw_reporter, "FW down reported", pdsc);
        pdsc_notify(PDS_EVENT_RESET, &reset_event);
 
        pdsc_stop(pdsc);
@@ -554,8 +555,9 @@ static void pdsc_fw_up(struct pdsc *pdsc)
 
        /* Notify clients of fw_up */
        pdsc->fw_recoveries++;
-       devlink_health_reporter_state_update(pdsc->fw_reporter,
-                                            DEVLINK_HEALTH_REPORTER_STATE_HEALTHY);
+       if (pdsc->fw_reporter)
+               devlink_health_reporter_state_update(pdsc->fw_reporter,
+                                                    DEVLINK_HEALTH_REPORTER_STATE_HEALTHY);
        pdsc_notify(PDS_EVENT_RESET, &reset_event);
 
        return;