s3/modules: cppcheck: Fix ctunullpointer error
authorNoel Power <noel.power@suse.com>
Wed, 22 May 2019 14:07:44 +0000 (14:07 +0000)
committerAndreas Schneider <asn@cryptomilk.org>
Tue, 4 Jun 2019 22:13:07 +0000 (22:13 +0000)
Fixes

source3/modules/vfs_syncops.c:117: error: ctunullpointer: Null pointer dereference: smb_fname <--[cppcheck]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/modules/vfs_syncops.c

index f94588c60ed09edfe2b8f0feb320678613ab82b6..0a51fdf6e7ad47c90ca1fad4716f9f5fb918dc1c 100644 (file)
@@ -113,11 +113,13 @@ static void syncops_two_names(const char *name1, const char *name2)
  */
 static void syncops_smb_fname(const struct smb_filename *smb_fname)
 {
-       char *parent;
-       parent = parent_dir(NULL, smb_fname->base_name);
-       if (parent) {
-               syncops_sync_directory(parent);
-               talloc_free(parent);
+       char *parent = NULL;
+       if (smb_fname != NULL) {
+               parent = parent_dir(NULL, smb_fname->base_name);
+               if (parent != NULL) {
+                       syncops_sync_directory(parent);
+                       talloc_free(parent);
+               }
        }
 }